Eliminate the need to write :host ::content instead of just ::content
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Sep 5, 2015
|
Thanks for the PR - apologies for the delay on feedback. To make it a little easier to discuss the impetus and reasoning behind the change, would you be able to create an issue that goes over the reasoning and then link to it from this PR? |
|
It was already created and linked back: #1727 |
nazar-pc
force-pushed
the
content-selector-fix
branch
from
7d22d5c to
39a5099
Compare
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Oct 8, 2015
Patches applied on top of stable version: * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2322 * Polymer/polymer#2349 * Polymer/polymer#2419
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 1, 2015
List of patches applied on top of stable version (one previous patch upstreamed, the rest are still here): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2663 * Polymer/polymer#2664
nazar-pc
force-pushed
the
content-selector-fix
branch
2 times, most recently
from
6a608b3 to
5d66b6b
Compare
|
Just rebased this against master to resolve conflicts and did some small improvements. |
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 6, 2015
List of patches applied on top of git version (2 previous patches upstreamed, the rest are still here + 2 new patches added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * Polymer/polymer#2692 * Polymer/polymer#2694
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 13, 2015
List of patches applied on top of git version (no new patches upstreamed since last time:(): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * https://github.com/Polymer/polymer/tree/fix-2692 branch supersedes Polymer/polymer#2692 * Polymer/polymer#2694
nazar-pc
force-pushed
the
content-selector-fix
branch
from
5d66b6b to
b1260e6
Compare
|
Rebased against master once again. Really simple fix, sad to see it is not merged months later 👎 |
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Dec 18, 2015
List of patches applied on top of git version (4 previous patches upstreamed and one fixed by alternative patch, yay!): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#3215
…ent`, while keeping the same processing under the hood
… regexp object only once
nazar-pc
force-pushed
the
content-selector-fix
branch
from
b1260e6 to
c6c28f5
Compare
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Feb 1, 2016
List of patches applied on top of git version (1 previous patch upstreamed, 4 more added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#3222 * Polymer/polymer#3344 * Polymer/polymer#3279 * Polymer/polymer#3276
|
LGTM. Sorry for the delay and thanks for the effort! |
sorvell
pushed a commit
that referenced
this pull request
Feb 4, 2016
Eliminate the need to write `:host ::content` instead of just `::content`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While keeping the same processing under the hood.
I've also removed workaround from tests and they don't fail, which is good.