Fix for loosing prototype's property value during getter/setter initialization #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 13, 2015
…w DOM, not Shady DOM!), rest of things are broken currently. Polymer includes patches that are proposed upstream: * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2258
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 15, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 17, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 20, 2015
Patches included: * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2258 * Polymer/polymer#2266 * Polymer/polymer#2286 (accepted upstream) * Polymer/polymer#2295 * Polymer/polymer#2322
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 22, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 26, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 29, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Sep 5, 2015
|
Adding @kevinpschaaf to match corresponding issue |
|
With master code causes errors, something changed withing Polymer:( |
|
Sorry for the delay and thanks for the effort here. The supported way to define default values for properties is via the value field for a property in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically prototype's value was overridden with accessor.
Check added - if instance value doesn't exist - use value from prototype, just like it work during regular prototype inheritance.
Fixes #2257 (partially)