Fix for method parsing in computed binding #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 17, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 20, 2015
Patches included: * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2258 * Polymer/polymer#2266 * Polymer/polymer#2286 (accepted upstream) * Polymer/polymer#2295 * Polymer/polymer#2322
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 22, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 26, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Aug 29, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Sep 5, 2015
|
Could you create a corresponding issue for this? It seems clear in the PR, but an issue will help the conversation. |
|
Issue: #2506 |
|
@tjsavage any word on this one? |
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Oct 8, 2015
Patches applied on top of stable version: * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2322 * Polymer/polymer#2349 * Polymer/polymer#2419
This was referenced Oct 16, 2015
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 1, 2015
List of patches applied on top of stable version (one previous patch upstreamed, the rest are still here): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2663 * Polymer/polymer#2664
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 6, 2015
List of patches applied on top of git version (2 previous patches upstreamed, the rest are still here + 2 new patches added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * Polymer/polymer#2692 * Polymer/polymer#2694
nazar-pc
force-pushed
the
method-parsing-fix
branch
from
cd70140 to
c2e43d3
Compare
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Nov 13, 2015
List of patches applied on top of git version (no new patches upstreamed since last time:(): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2295 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#2642 * Polymer/polymer#2689 * https://github.com/Polymer/polymer/tree/fix-2692 branch supersedes Polymer/polymer#2692 * Polymer/polymer#2694
|
LGTM |
dfreedm
added a commit
that referenced
this pull request
Dec 4, 2015
Fix for method parsing in computed binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantifier should be greedy, otherwise it fails to parse correctly such construction: