Fix for scoping when class is not specified on element #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Dec 20, 2015
|
Could you add a little test to prevent regressions? Otherwise LGTM 👍 |
nazar-pc
force-pushed
the
fix-for-scoping-empty-class
branch
from
4e223b3 to
57f0df0
Compare
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Feb 1, 2016
List of patches applied on top of git version (1 previous patch upstreamed, 4 more added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#3222 * Polymer/polymer#3344 * Polymer/polymer#3279 * Polymer/polymer#3276
|
Please add a test case that tests the problem this PR is fixing. See CONTRIBUTING.md for more details. |
…ended instead of empty string)
nazar-pc
force-pushed
the
fix-for-scoping-empty-class
branch
from
57f0df0 to
24e9fc7
Compare
|
Test is here |
|
LGTM, thx! |
sorvell
pushed a commit
that referenced
this pull request
Feb 11, 2016
Fix for scoping when class is not specified on element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If class on element is not present then
And as result:
While just
style-scopewas expected.