Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for node 18, dropping node 12 #406

Merged
merged 6 commits into from
Apr 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: debugging
erunion committed Apr 20, 2022
commit d593b14771c9967a3e6d168691eea1370303ecc5
10 changes: 7 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -11,9 +11,12 @@ jobs:

strategy:
matrix:
# node 16.14.2 ships with a buggy version of npm 🤷‍♂️
# https://github.com/nodejs/node/issues/42397
# TODO revert this back to 16.x when node pushes a new version
node-version:
- 14
- 16
- 16.14.0
- 18

steps:
@@ -22,9 +25,10 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

# Node 14 still ships with npm@6, and Node 16.14.2 ships with a buggy version of npm so for
# compatibility reasons we're installing the latest version of npm
# Node 14 still ships with npm@6 so for compatibility reasons we're upping
# this to match everything else.
- name: Install npm@8
if: matrix.node-version == '14'
run: npm install -g npm@8

- run: npm ci