feat: adding support for node 18, dropping node 12

.github/workflows/nodejs.yml

@@ -14,23 +14,17 @@ jobs:
         # node 16.14.2 ships with a buggy version of npm 🤷‍♂️
         # https://github.com/nodejs/node/issues/42397
         # TODO revert this back to 16.x when node pushes a new version
-        node-version: [12.x, 14.x, 16.14.0]
+        node-version:
+          - 12
+          - 14
+          - 16.14.0
+          - 18
 
     steps:
       - uses: actions/checkout@v3
-
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-
-      - name: Install npm@7
-        run: npm install -g npm@7
-
-      - name: Install deps
-        run: npm ci
-
-      - name: Run tests
-        run: npm test
 
-        env:
-          CI: true
+      - run: npm ci
+      - run: npm test

package.json

@@ -14,7 +14,7 @@
     "url": "https://github.com/readmeio/metrics-sdks.git"
   },
   "engines": {
-    "node": "^12 || ^14 || ^16"
+    "node": ">=14"
   },
   "workspaces": [
     "./packages/node"

packages/node/package.json

@@ -17,7 +17,7 @@
     "readme"
   ],
   "engines": {
-    "node": "^12 || ^14 || ^16"
+    "node": ">=14"
   },
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",
@@ -34,7 +34,7 @@
     "uuid": "^8.2.0"
   },
   "devDependencies": {
-    "@readme/eslint-config": "^8.4.4",
+    "@readme/eslint-config": "^8.7.0",
     "@types/har-format": "^1.2.7",
     "@types/jest": "^27.4.1",
     "@types/multer": "^1.4.7",

packages/node/src/lib/express-middleware.ts

@@ -129,7 +129,7 @@ export function expressMiddleware(readmeApiKey: string, group: GroupingFunction,
       queue.push(payload);
       if (queue.length >= bufferLength) doSend();
 
-      cleanup(); // eslint-disable-line no-use-before-define
+      cleanup(); // eslint-disable-line @typescript-eslint/no-use-before-define
     }
 
     function cleanup() {