Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for node 18, dropping node 12 #406

Merged
merged 6 commits into from
Apr 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add --ignore-scripts to npm ci in github action
I think we were reliant on buggy behaviour in npm@7 where `npm ci`
wasn't running some of the lifecycle hooks:
npm/cli#1905 (comment)

This got fixed in npm@8 but now our CI process breaks:
npm/cli@d825e90

Decided to follow the recommendations from husky's docs to do this so it
doesnt run the `prepare` step:

```sh
npm ci --ignore-scripts
```

https://github.com/typicode/husky/blob/0bcdac6b4dad6eedecc49cf3837ecc05b321db2e/docs/README.md#disable-husky-in-cidockerprod=
domharrington committed Apr 21, 2022
commit 864e29141d04865ed0ba90615bd6852ec8d20c2b
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -31,5 +31,5 @@ jobs:
if: matrix.node-version == '14'
run: npm install -g npm@8

- run: npm ci
- run: npm ci --ignore-scripts
- run: npm test