Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to Portuguese (Portugal) #4736

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Conversation

rmmineiro
Copy link
Contributor

@rmmineiro rmmineiro commented Apr 6, 2020

Portuguese (Portugal) translation based on Portuguese (Brazil). Made a few changes and in other cases kept the Brazil version due to lack of context.

Thanks for your interest in plotly.js!

Translations:

  • Make a PR directly to the main repository
  • Please @ mention a few other speakers of this language who can help review your translations.
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/

Portuguese (Portugal) translation based on Portuguese (Brazil). Made a few changes and in other cases I kept the Brazil version due to lack of context.
@archmoj archmoj changed the title Create pt-pt.js Translation to Portuguese (Portugal) Apr 7, 2020
@archmoj archmoj added community community contribution type: translation labels Apr 7, 2020
@archmoj
Copy link
Contributor

archmoj commented Apr 7, 2020

Thanks @rmmineiro
Could you please @ mention a few other speakers of this language who can help review your translations?

@rmmineiro
Copy link
Contributor Author

@archmoj from the top of my head I can think of a few, say Cristiano Ronaldo, I´m just not sure he is using github :) Now, seriously, I can try to have it checked by a 'certified' translator but anyone looking at this will need to be familiar with plotly context which does not make things easier (I am not using the complete distribution myself). So, if I don´t get back to you in a few days is because I do not have any changes to propose. Looking back at the translation I suggest one change in the key 'Zoom' to ' Ampliar'. I have doubts in a few cases such as ´Pan´ but I guess 'Mover' is not too far off. In fact, all Portuguese (Brazil) translations are mostly understandable in Portuguese (Portugal), it´s just that some expressions are not commonly used (some hurting the ear a bit, say ‘Restaurar visão‘ or ´Fechamento´). Finally, I am using all these keys without any English fall back because I have users that do not understand English and would have difficulty using the graphs otherwise.

@archmoj
Copy link
Contributor

archmoj commented Apr 9, 2020

@joaoalf do you know anyone that could help with reviewing this PR?

@archmoj archmoj added this to the v1.54.0 milestone Apr 9, 2020
@rmmineiro
Copy link
Contributor Author

@archmoj can you point me to a turntable rotation example?

@archmoj
Copy link
Contributor

archmoj commented Apr 13, 2020

@archmoj can you point me to a turntable rotation example?

Here is a demo.

Translation now "ATA Certified".
@archmoj archmoj requested a review from alexcjohnson April 20, 2020 15:18
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 There aren't so many changes relative to pt-br so I think it's OK to merge. Flagging @vinipitta and @andrefarzat - author and reviewer of the pt-br PR anyway, in case they either have comments about this one, or might want to pull any of these changes back to the Brazilian version.

@andrefarzat
Copy link
Contributor

@alexcjohnson It seems ok for me 💃

@archmoj archmoj merged commit 22dd9c1 into plotly:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants