This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Remove threshold from getbalances API call #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acha-bill
changed the title
kwek20
approved these changes
Feb 27, 2020
|
Actually we forgot to remove it from the regression tests as well |
kwek20
pushed a commit
to kwek20/iri
that referenced
this pull request
Mar 10, 2020
This was referenced Mar 13, 2020
Merged
Open
laumair
added a commit
to laumair/iota.js
that referenced
this pull request
Jun 8, 2020
IRI removes support for threshold parameter in version [1.8.6](iotaledger/iri#1768). This PR removes the usage of threshold parameter from the lib. Related: iotaledger/iri#1851
laumair
pushed a commit
to iotaledger/iota.js
that referenced
this pull request
Jun 14, 2020
IRI removes support for threshold parameter in version [1.8.6](iotaledger/iri#1768). This PR removes the usage of threshold parameter from the lib. Related: iotaledger/iri#1851
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused
thresholdparameter fromgetBalancesAPI call.Fixes #1723
Type of change
How Has This Been Tested?
getBalanceson a node with and without threshold.Checklist: