Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

getBalances will no longer require a threshold #22

Closed
JakeSCahill opened this issue Mar 13, 2020 · 0 comments · Fixed by #35
Closed

getBalances will no longer require a threshold #22

JakeSCahill opened this issue Mar 13, 2020 · 0 comments · Fixed by #35

Comments

@JakeSCahill
Copy link
Contributor

Bug description

In this PR, the threshold parameter is removed from the getBalances endpoint on IRI nodes.

Currently, this is a required parameter is the library, so we should make it optional.

Expected behaviour

The threshold parameter is optional (for backwards compatibility)

Actual behavior

The threshold parameter is required

Am I planning to do it myself with a PR?

No.
@oopsmonk oopsmonk mentioned this issue May 29, 2020
Merged
6 tasks
howjmay pushed a commit to howjmay/iota.c that referenced this issue Jul 9, 2020
Update rules_iota, fixed compiling errors on kerl. (iotaledger#22)
1b56a52 
* Update rules_iota, fixed compiling errors on kerl.

* Update keccak cmake script.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API changes on iota_client_get_inclusion_states and iota_client_get_balances oopsmonk/iota.c
1 participant
@JakeSCahill