Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetBalances will no longer require a threshold #149

Closed
JakeSCahill opened this issue Mar 13, 2020 · 0 comments · Fixed by #170
Closed

GetBalances will no longer require a threshold #149

JakeSCahill opened this issue Mar 13, 2020 · 0 comments · Fixed by #170

Comments

@JakeSCahill
Copy link
Contributor

Bug description

In this PR, the threshold parameter is removed from the getBalances endpoint on IRI nodes.

Currently, this is a required parameter is the library, so we should make it optional.

Expected behaviour

The threshold parameter is optional (for backwards compatibility)

Actual behavior

The threshold parameter is required

Am I planning to do it myself with a PR?

No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates node API functions to reflect newest changes iotaledger/iota.go
1 participant
@JakeSCahill