Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatekH743 board_id, usb vid/pid changes, and MPU6000 delay before transfer - not after #18733

Merged
merged 15 commits into from
Feb 8, 2022

Conversation

vvladic
Copy link
Contributor

@vvladic vvladic commented Nov 27, 2021

Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.

Describe problem solved by this pull request
Board_id not compatible with ardupilot, uninitialized gpio outputs, delay before transfer not after in MPU6000

Describe your solution
Corrected board id, initialized outputs, moved delay before spi transfer

Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.

Test data / coverage
Bench tested: bootloader OK, pins enabled permanently for now, MPU6000 delay moved before spi transfer

@vvladic vvladic mentioned this pull request Nov 27, 2021
@taileron
Copy link
Contributor

@vvladic how about remove the suffix "slim" from your target which, by the way, also runs perfectly on the mini fc. Having an unified target that should run on all variants of this fc (like AP does). By adding appropriate modules, mc, fw and vtol would be feasible with the code. #18730 Only one folder would have to be maintained ...

@vvladic vvladic requested a review from dagar January 30, 2022 20:17
@vvladic
Copy link
Contributor Author

vvladic commented Feb 7, 2022

@vvladic how about remove the suffix "slim" from your target which, by the way, also runs perfectly on the mini fc. Having an unified target that should run on all variants of this fc (like AP does). By adding appropriate modules, mc, fw and vtol would be feasible with the code. #18730 Only one folder would have to be maintained ...

We can do this in another pull request perhaps, after we merge this one. Would that be ok?

@vvladic
Copy link
Contributor Author

vvladic commented Feb 7, 2022

@dagar Can we merge this? Is there anything else that you wish to be done before merging?

@dagar
Copy link
Member

dagar commented Feb 7, 2022

@dagar Can we merge this? Is there anything else that you wish to be done before merging?

Are you sure the flash based parameters are working on H7? Last I heard there was an issue due to the ECC.

@dagar
Copy link
Member

dagar commented Feb 7, 2022

Maybe leave the flash based parameter changes commented and we'll merge the rest right now?

@vvladic
Copy link
Contributor Author

vvladic commented Feb 7, 2022

Maybe leave the flash based parameter changes commented and we'll merge the rest right now?

It's already disabled in board_config.h

/****************************************************************************************************
* Definitions
****************************************************************************************************/
// #define FLASH_BASED_PARAMS

Would you like me to comment it out of src/init.c as well?

@dagar
Copy link
Member

dagar commented Feb 7, 2022

Would you like me to comment it out of src/init.c as well?

Yes please, let's try to make it as obvious as possible.

@dagar
Copy link
Member

dagar commented Feb 7, 2022

Thanks @vvladic

@taileron
Copy link
Contributor

taileron commented Feb 8, 2022

@vvladic how about remove the suffix "slim" from your target which, by the way, also runs perfectly on the mini fc. Having an unified target that should run on all variants of this fc (like AP does). By adding appropriate modules, mc, fw and vtol would be feasible with the code. #18730 Only one folder would have to be maintained ...

We can do this in another pull request perhaps, after we merge this one. Would that be ok?

no problem, but this board now also uses IMU ICM42605 instead of ICM20602 in the current version

@dagar dagar merged commit f4d02a2 into PX4:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants