-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatekH743 board_id, usb vid/pid changes, and MPU6000 delay before transfer - not after #18733
Conversation
@vvladic how about remove the suffix "slim" from your target which, by the way, also runs perfectly on the mini fc. Having an unified target that should run on all variants of this fc (like AP does). By adding appropriate modules, mc, fw and vtol would be feasible with the code. #18730 Only one folder would have to be maintained ... |
We can do this in another pull request perhaps, after we merge this one. Would that be ok? |
@dagar Can we merge this? Is there anything else that you wish to be done before merging? |
Are you sure the flash based parameters are working on H7? Last I heard there was an issue due to the ECC. |
Maybe leave the flash based parameter changes commented and we'll merge the rest right now? |
It's already disabled in board_config.h PX4-Autopilot/boards/matek/h743-slim/src/board_config.h Lines 52 to 57 in 5b07398
Would you like me to comment it out of src/init.c as well? |
Yes please, let's try to make it as obvious as possible. |
Thanks @vvladic |
no problem, but this board now also uses IMU ICM42605 instead of ICM20602 in the current version |
Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
Board_id not compatible with ardupilot, uninitialized gpio outputs, delay before transfer not after in MPU6000
Describe your solution
Corrected board id, initialized outputs, moved delay before spi transfer
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Test data / coverage
Bench tested: bootloader OK, pins enabled permanently for now, MPU6000 delay moved before spi transfer