feat: add screen loading manual & automatic approaches #477

AndrewAminInstabug · 2024-06-09T21:04:46Z

Description of the change

This pull request includes the necessary implementation for both manual and automatic (Navigator 1) screen loading approaches.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: APM-19229

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests

Code review

This pull request has a descriptive title and information useful to a reviewer
Issue from task tracker has a link to this pull request

Deprecate execution traces in favor of AppFlows APIs.

Added the network_security_config configuration to support proxy tools for android

This resolves the issue on jetbrains IDEs where the dart analyzer doesn't start up nor the linting, intentions and auto-complete features.

Support native and flutter crash scenarios as well as adding Crashes Method Channels. Jira ID: - APM-19526 - APM-19645

- Added a new button widget called InstabugClipboardIconButton. - This widget provides a button with an icon to paste text from the clipboard. - The widget accepts an optional callback function `onPaste` to handle the pasted text.

- Added a new widget called InstabugClipboardInput. - This widget combines InstabugTextField and InstabugClipboardIconButton to provide an input field with a button to paste text from the clipboard. - The widget accepts label and controller parameters to customize the input field.

- Added `http` package to the `pubspec.yaml` file with version constraint `^0.13.6`. - This package is required to perform HTTP requests for network monitoring functionality in the APM feature.

- Added ApmBody widget to display APM (Application Performance Monitoring) related content. - Introduced NetworkContent widget within ApmBody to handle network monitoring functionality. - NetworkContent includes an input field for the endpoint URL and a button to send a request to the specified URL. - The button triggers an HTTP GET request to the provided URL and logs the response data or any error encountered.

Introduces a new constructor to the InstabugButton widget, to allow creation of create buttons with a smaller font size. The new constructor, InstabugButton.smallFontSize, accepts parameters for text, onPressed callback, fontSize (defaulting to 10.0), and margin. This addition enhances the flexibility of the InstabugButton widget.

- Add a new optional parameter, labelStyle, to the InstabugTextField widget; allowing style customization. - Set icon size to 12.0

- Added `TracesContent` widget to display trace-related UI elements. - Implemented functionality to start, delay start, and end traces. - Implemented setting trace attributes. - Added error handling for various scenarios such as starting a trace without a name, ending a trace without starting one, and setting attributes without starting or after ending a trace. - Updated UI to include buttons for starting, delaying start, ending traces, and setting trace attributes.

…ws-with-apm-and-crashes-example

Co-authored-by: Ahmed Mahmoud <[email protected]>

…to feat/support-app-flows

Co-authored-by: Ahmed Mahmoud <[email protected]>

…-loading

…support-manual-screen-loading

The SessionReplayLink InstabugButton was placed inside of the Color Theme ButtonBar resulting in infinite width issue.

…-screen-loading-nav-1 # Conflicts: # android/build.gradle

…oading-nav-1 add: SCL automatic approach nav 1

InstabugCI · 2024-06-09T21:07:17Z

	Warnings
⚠️	You have not included a CHANGELOG entry! You can find it at CHANGELOG.md.

Coverage Report

Label	Coverage	Status
Dart	82.0%	✅

Generated by 🚫 dangerJS against df6f5eb

android/build.gradle

android/src/main/java/com/instabug/flutter/modules/ApmApi.java

android/src/test/java/com/instabug/flutter/SessionReplayApiTest.java

* feat: support Variants in Features & Experiments APIs * fix: deprecated comment * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix removeFeaturFlag test case * test: decommission native e2e tests in favor of captain (#484) * chore(android): bump sdk to 13.2.0 (#482) * chore(ios): bump sdk to v13.2.0 (#483) * feat: add screen loading manual & automatic approaches (#477) * release: v13.2.0 (#485) * fix: format files * fix: format files * fix: format files * fix: pr comments * fix: PR comments * fix: PR comments * fix: PR comments * fix: PR comments * fix: PR comments * chore: correct pr number in changelog * chore: correct pr number in changelog * chore: correct changelog section level * refactor: remove unnecessary `List.of` * chore: mention variants support in changelog --------- Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: Andrew Amin <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]>

abdelhamid-f-nasser and others added 30 commits February 21, 2024 12:40

chore: deprecate execution traces APIs

59bccda

Deprecate execution traces in favor of AppFlows APIs.

feat: support app flows

ca3c399

chore: reformat files

9c09365

docs: update changelog.md

537038d

docs: update deprecation notice with APM prefix

ea5a5a8

chore(example): add network_security_config to support proxy

1167181

Added the network_security_config configuration to support proxy tools for android

chore(example): add flutter_lints for dart analysis

1080627

This resolves the issue on jetbrains IDEs where the dart analyzer doesn't start up nor the linting, intentions and auto-complete features.

feat(example): add crash buttons

0e65509

Support native and flutter crash scenarios as well as adding Crashes Method Channels. Jira ID: - APM-19526 - APM-19645

refactor(example): extract components to separate files

847f127

feat(example): introduce instabug_clipboard_icon_button

3061809

- Added a new button widget called InstabugClipboardIconButton. - This widget provides a button with an icon to paste text from the clipboard. - The widget accepts an optional callback function `onPaste` to handle the pasted text.

build(example): add http package

0effd8d

- Added `http` package to the `pubspec.yaml` file with version constraint `^0.13.6`. - This package is required to perform HTTP requests for network monitoring functionality in the APM feature.

feat(example): enhance instabug_text_field with customizable label style

c50db3d

- Add a new optional parameter, labelStyle, to the InstabugTextField widget; allowing style customization. - Set icon size to 12.0

WIP: adding app flows snapshot

f5a1696

refactor: change flow attribute value to nullable

d1687b0

Merge branch 'feat/support-app-flows' into feat/combo-support-app-flo…

f9751ca

…ws-with-apm-and-crashes-example

chore: update ios snapshot

bb02359

Update CHANGELOG.md

1e6c5e5

Co-authored-by: Ahmed Mahmoud <[email protected]>

Merge branch 'dev' of https://github.com/Instabug/Instabug-Flutter in…

6626393

…to feat/support-app-flows

Update lib/src/modules/apm.dart

5938b43

Co-authored-by: Ahmed Mahmoud <[email protected]>

Merge branch 'feat/support-app-flows' into feat/support-manual-screen…

2ec2229

…-loading

Merge remote-tracking branch 'origin/feat/add-apm-buttons' into feat/…

b43037f

…support-manual-screen-loading

feat: support screen loading monitoring

88f5f98

refactor(example): move apm and crashes to separate pages

45f5f58

fix(example): resolve infinite width for SessionReplayLink

3377e7a

The SessionReplayLink InstabugButton was placed inside of the Color Theme ButtonBar resulting in infinite width issue.

feat(example): add complex widget page

22f269c

AndrewAminInstabug added 5 commits June 9, 2024 12:02

chore: run dart fix and flutter format

f4ac87f

Merge remote-tracking branch 'origin/dev' into feat/support-automatic…

8eafcf2

…-screen-loading-nav-1 # Conflicts: # android/build.gradle

chore: pull ci changes from dev

5d7cda2

fix: screen_loading_manager_test to pass flutter 2

0615009

Merge pull request #476 from Instabug/feat/support-automatic-screen-l…

3ac947f

…oading-nav-1 add: SCL automatic approach nav 1

AndrewAminInstabug requested review from ahmedAlaaInstabug and kholood-ea June 9, 2024 21:04

ahmedAlaaInstabug reviewed Jun 11, 2024

View reviewed changes

android/build.gradle Outdated Show resolved Hide resolved

ahmedAlaaInstabug reviewed Jun 11, 2024

View reviewed changes

android/src/main/java/com/instabug/flutter/modules/ApmApi.java Show resolved Hide resolved

ahmedAlaaInstabug reviewed Jun 11, 2024

View reviewed changes

android/src/test/java/com/instabug/flutter/SessionReplayApiTest.java Outdated Show resolved Hide resolved

fix: SessionReplayApiTest hashed test

e4fc848

AndrewAminInstabug changed the title ~~add: screen loading manual & automatic approches~~ feat: screen loading manual & automatic approches Jun 11, 2024

AndrewAminInstabug changed the title ~~feat: screen loading manual & automatic approches~~ feat: screen loading manual & automatic approaches Jun 11, 2024

Base automatically changed from dev to master June 11, 2024 12:31

AndrewAminInstabug and others added 3 commits July 7, 2024 12:42

Merge remote-tracking branch 'origin/dev' into feat/screen-loading

fc101af

chore: remove duplicate dependency in example pubspec

0adc55e

chore(ios): remove ios snapshot

7043c29

a7medev changed the base branch from master to dev July 7, 2024 10:41

a7medev changed the title ~~feat: screen loading manual & automatic approaches~~ feat: add screen loading manual & automatic approaches Jul 7, 2024

test: skip change report types e2e test as it's flaky

df6f5eb

a7medev requested a review from ahmedAlaaInstabug July 7, 2024 11:41

ahmedAlaaInstabug approved these changes Jul 7, 2024

View reviewed changes

mzelzoghbi merged commit 8e0ff8d into dev Jul 7, 2024
11 checks passed

mzelzoghbi deleted the feat/screen-loading branch July 7, 2024 12:23

mzelzoghbi pushed a commit that referenced this pull request Jul 7, 2024

feat: add screen loading manual & automatic approaches (#477)

554c17f

ahmedAlaaInstabug pushed a commit that referenced this pull request Nov 4, 2024

feat: add screen loading manual & automatic approaches (#477)

af38253

ahmedAlaaInstabug pushed a commit that referenced this pull request Nov 4, 2024

feat: add screen loading manual & automatic approaches (#477)

81705e8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add screen loading manual & automatic approaches #477

feat: add screen loading manual & automatic approaches #477

Uh oh!

AndrewAminInstabug commented Jun 9, 2024

Uh oh!

InstabugCI commented Jun 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: add screen loading manual & automatic approaches #477

feat: add screen loading manual & automatic approaches #477

Uh oh!

Conversation

AndrewAminInstabug commented Jun 9, 2024

Description of the change

Type of change

Related issues

Checklists

Development

Code review

Uh oh!

InstabugCI commented Jun 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

InstabugCI commented Jun 9, 2024 •

edited

Loading