Skip to content

add: SCL automatic approach nav 1 #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 9, 2024
Merged

add: SCL automatic approach nav 1 #476

merged 18 commits into from
Jun 9, 2024

Conversation

AndrewAminInstabug
Copy link
Contributor

Description of the change

This PR includes the logic for measuring screen loading using Flutter Navigator 1 API, as well as an example app refactoring.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID:

Checklists

Development

  • Lint rules pass locally
  • [ x The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

AndrewAminInstabug and others added 15 commits May 22, 2024 13:00
@AndrewAminInstabug
chore: add automatic approach nav 1
363e4e9
@AndrewAminInstabug
feat: add SCL automatic approach for Navigator1,
7760240 
refactor: sample app by moving widgets in main.dart to separate files
@AndrewAminInstabug
Merge branch 'feat/support-manual-screen-loading' into feat/support-a…
688020d 
…utomatic-screen-loading-nav-1
@AndrewAminInstabug
feat: add unit test for navigator 1 wrapRoutes method
15418b0
@AndrewAminInstabug
feat: add screen name sanitization unit tests and fix bug in its logic
c9aab81
@AndrewAminInstabug
fix: update example app to capture home page
3d60da7
@AndrewAminInstabug
Merge remote-tracking branch 'origin/feat/support-manual-screen-loadi…
5d55c8a 
…ng' into feat/support-automatic-screen-loading-nav-1

# Conflicts:
#	lib/src/modules/apm.dart
@AndrewAminInstabug
chore: remove unused codes & format files
f51825d
@ahmedAlaaInstabug
chore(android): bump SDK to v13.1.1
3f73dfe
@ahmedAlaaInstabug
docs: fix changeLog
4d44acd
@ahmedAlaaInstabug
Merge branch 'dev' into chore(android)-bump-sdk-to-v13.1.1
1964d93
@AndrewAminInstabug
Merge pull request #474 from Instabug/chore(android)-bump-sdk-to-v13.1.1
e0e0a42 
chore(android): bump SDK to v13.1.1
@ahmedAlaaInstabug
chore(iOS): bump sdk to v13.1.0 (#473)
562b0f1 
* chore(ios): bump SDK to v13.1.0

* chore(ios): bump SDK to v13.1.0

* docs: fix changeLog
@AndrewAminInstabug
Merge remote-tracking branch 'origin/feat/support-automatic-screen-lo…
ad80239 
…ading-nav-1-unit-tests' into feat/support-automatic-screen-loading-nav-1
@AndrewAminInstabug
chore: run dart fix and flutter format
f4ac87f
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jun 9, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 82.4% ✅

Generated by 🚫 dangerJS against 0615009

@AndrewAminInstabug AndrewAminInstabug merged commit 3ac947f into feat/screen-loading Jun 9, 2024
9 of 11 checks passed
@AndrewAminInstabug AndrewAminInstabug deleted the feat/support-automatic-screen-loading-nav-1 branch June 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewAminInstabug @InstabugCI @ahmedAlaaInstabug