feat: support variants in feature flags #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # android/build.gradle
# Conflicts: # CHANGELOG.md # android/src/main/java/com/instabug/flutter/modules/InstabugApi.java # example/ios/Podfile # example/ios/Podfile.lock # example/lib/main.dart # ios/Classes/Modules/InstabugApi.m
android/src/test/java/com/instabug/flutter/InstabugApiTest.java
Outdated
Show resolved
Hide resolved
android/src/test/java/com/instabug/flutter/InstabugApiTest.java
Outdated
Show resolved
Hide resolved
AndrewAminInstabug
previously approved these changes
Jul 17, 2024
AndrewAminInstabug
previously approved these changes
Jul 17, 2024
AndrewAminInstabug
previously approved these changes
Jul 18, 2024
a7medev
changed the title
a7medev
requested changes
Jul 31, 2024
Comment on lines
+239
to
+242
| List<IBGFeatureFlag> features = new ArrayList<>(); | ||
| for (Map.Entry<String, String> entry : featureFlags.entrySet()) { | ||
| features.add(new IBGFeatureFlag(entry.getKey(), entry.getValue().isEmpty() ? null : entry.getValue())); | ||
| } |
There was a problem hiding this comment.
BTW we can use Java 8 streams here instead if you think they will be more readable, I'm okay with keeping this one as well.
a7medev
approved these changes
Aug 4, 2024
ahmedAlaaInstabug
added a commit
that referenced
this pull request
Nov 4, 2024
* feat: support Variants in Features & Experiments APIs * fix: deprecated comment * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix: removeFeatureFlagsFeatureFlag catch * fix removeFeaturFlag test case * test: decommission native e2e tests in favor of captain (#484) * chore(android): bump sdk to 13.2.0 (#482) * chore(ios): bump sdk to v13.2.0 (#483) * feat: add screen loading manual & automatic approaches (#477) * release: v13.2.0 (#485) * fix: format files * fix: format files * fix: format files * fix: pr comments * fix: PR comments * fix: PR comments * fix: PR comments * fix: PR comments * fix: PR comments * chore: correct pr number in changelog * chore: correct pr number in changelog * chore: correct changelog section level * refactor: remove unnecessary `List.of` * chore: mention variants support in changelog --------- Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: Andrew Amin <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
JIRA ID: MOB-14685
Checklists
Development
Code review