[No QA] Replace usages of useWindowDimensions with useResponsiveLayout in components folder

[rayane-d]

cc @getusha

Details

#30528 (comment)

Fixed Issues

$ #30528

Tests

Perform general regression testing verifying that app layouts and styles are correct.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Recording.2024-03-28.025954.mp4

Android: mWeb Chrome

Recording.2024-03-28.024503.mp4

iOS: Native

Recording.2024-03-28.023602.mp4

iOS: mWeb Safari

Recording.2024-03-28.024006.mp4

MacOS: Chrome / Safari

Recording.2024-03-28.024149.mp4

MacOS: Desktop

Recording.2024-03-28.024756.mp4

[melvin-bot]

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

@MonilBhavsar you can unassign yourself. this part of #30528, @getusha will review

[getusha]

@rayane-djouah looks like we have a merge conflict.

[getusha]

@rayane-djouah I think we need to add QA steps or mark it as No QA?

[getusha]

@rayane-djouah check my comments please.

[rayane-d]

sorry for the delay @getusha
I updated the PR

[rayane-d]

@rayane-djouah I think we need to add QA steps or mark it as No QA?

I think that we should ask QA team to do regression testing with an Ad-hoc build before we merge, what do you think?

[rayane-d]

I think that we should ask QA team to do regression testing with an Ad-hoc build before we merge, what do you think?

what do you think @roryabraham about ^

[roryabraham]

Hmmm I think that sounds like it might be overkill in this case, but I'll make an AdHoc build

[rayane-d]

it didn't work @roryabraham

[roryabraham]

ah, sorry I think I was on mobile and couldn't kick it off. Doing that now...

[rayane-d]

Yeah, looks like the RHP opening animation is not smooth when opening Settings > Status. But after refreshing the settings page, the animation is smooth:

Screen.Recording.2024-05-10.at.6.04.29.PM.mov

I'm investigating which change caused it.

[rayane-d]

Fixed the bug: 501e619. The cause was that there were additional rerenders when isVisible was changing, because useResponsiveLayout was dependent on the entire modal object.

[getusha]

Staging	This PR
Screen.Recording.2024-05-12.at.3.58.18.in.the.afternoon.mov	Screen.Recording.2024-05-12.at.3.57.47.in.the.afternoon.mov

@rayane-djouah it still feels like there is a difference can you compare it with staging? it's not much i think we can ignore it, if it is not possible to fix. @roryabraham wdyt?

[rayane-d]

I think that this difference is because we are reading a value from Onyx storage, but I think its minor and we can ignore it, what do you think @roryabraham ?

[roryabraham]

Looks similar enough to me to ignore 👍🏼

[getusha]

lgtm!

[melvin-bot]

🎯 @getusha, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #42371.

[roryabraham]

Merge freeze is still in effect for now

[roryabraham]

Merge freeze is lifted, I will try to review this today

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Christinadobrzyn]

hey @roryabraham and @getusha we might have a regression - can you check - #42886 (comment)

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅