[Search v1] Add bulk actions #44385

WojtekBoman · 2024-06-25T12:02:31Z

Details

This PR adds support for bulk actions in the Search tab.

Screen.Recording.2024-07-01.at.17.33.55.mov

Fixed Issues

$ #39887
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Launch the app.
Open the Search tab.
Verify if selecting checkboxes works correctly for TransactionListItems and ReportItems.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

This functionality is only supported on wide screen.

MacOS: Chrome / Safari

Screen.Recording.2024-07-01.at.17.33.55.mov

MacOS: Desktop

Screen.Recording.2024-07-02.at.17.04.12.mov

src/libs/API/parameters/DeleteMoneyRequestOnSearchParams.ts

luacmartins · 2024-06-27T15:13:14Z

@WojtekBoman FYI the PR for DeleteMoneyRequestOnSearch was merged today and should be available in production soon so you can start testing that case.

trjExpensify · 2024-06-28T13:33:48Z

👋 @WojtekBoman how are you getting on here? Just a heads up that the basic CSV export project is a critical deliverable for GBTA (conference) on July 22nd. As the work to add the selection checkboxes to the Search page has begun with this PR, it's now effectively a blocker to getting that project complete before the conference.

We're starting on imp today, and @rlinoz will work on the backend in the meantime, but it would be good to clear this dependency ASAP.

luacmartins · 2024-06-28T15:28:34Z

@WojtekBoman given this is a blocker and the hold/unhold commands are not ready yet. Let's implement only Delete for now and we add hold/unhold as a follow up

trjExpensify · 2024-06-28T15:32:01Z

Great idea!

melvin-bot · 2024-07-01T15:37:35Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

WojtekBoman · 2024-07-02T14:51:59Z

Bug: No confirm modal is shown when choosing the delete option on the search page.

On the transaction page, we display this confirm modal:

Not sure if this is considered a bug or expected:

Login with an account that has a lot of expenses

Open search page

Click on the Select All checkbox

Scroll down to load more expenses

Notice that the loaded expenses are not selected

Screen.Recording.2024-07-02.at.1.47.08.AM.mov

@luacmartins I don't know if we should address these 2 cases. If so, could we create followups and merge this PR? I'll be OOO from 03.07 to 08.07 and wouldn't like to hold CSV export.

luacmartins · 2024-07-02T18:31:59Z

@luacmartins I don't know if we should address these 2 cases. If so, could we create followups and merge this PR? I'll be OOO from 03.07 to 08.07 and wouldn't like to hold CSV export.

Yea, I think addressing them as follow ups is fine. That being said, I'm unsure if we need to address them too. I think yes for the delete confirm modal, but no for the scroll checkbox issue.

luacmartins

Left a few comments. I'll get this PR merged since none of them are blockers. Let's address them in a follow up though!

luacmartins · 2024-07-02T18:42:25Z

src/components/Search/SearchPageHeader.tsx

+                value: CONST.SEARCH.BULK_ACTION_TYPES.HOLD,
+                onSelected: () => {
+                    clearSelectedItems?.();
+                    SearchActions.holdMoneyRequestOnSearch(hash, itemsToHold, '');


We'll still need to redirect the user to the reason page. Maybe that's something that @Kicu can address in his PR?

luacmartins · 2024-07-02T18:43:54Z

src/components/Search/index.tsx

+        return (
+            <>
+                <SearchPageHeader
+                    selectedItems={{}}


Could we just add a default to the component prop instead of passing this empty object? This just looks odd.

luacmartins · 2024-07-02T18:43:58Z

src/components/Search/index.tsx

+        return (
+            <>
+                <SearchPageHeader
+                    selectedItems={{}}


luacmartins · 2024-07-02T18:47:35Z

@WojtekBoman we have conflicts

WojtekBoman · 2024-07-02T19:36:47Z

@WojtekBoman we have conflicts

Solved :)

OSBotify · 2024-07-02T19:45:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Kicu · 2024-07-03T06:38:28Z

I will go over this PR and address any followups required in a separate PR

Kicu · 2024-07-03T13:37:22Z

@luacmartins about this:

We'll still need to redirect the user to the reason page.

Here is a small possibile future issue that I would like to discuss. Right now when displaying the Reason modal for 1 hold, we pass the id from Search view to RHP via a param. The URL on my PR looks like this .../search/all/hold/3802232314780767339/1656485478.

However if we also want to display the same modal for bulk actions, then there is no limit to the amount of transactions a user can check. If we continue to pass them, we would have to change url to something like: .../search/all/hold/?transactionIds=12345,54321,... - or something similar. That is we would have to encode a list of x amount of transaction ids. It feels a bit risky because in theory a user could select 100+ or more transactions and we could hit the URL length limit.

Any other way of handling this would have to involve onyx I guess, where we save the selection in onyx, navigate to RHP hold reason page and then read from onyx.
Or is there any other method of passing such context data to view that I'm missing? CC @adamgrzybowski what do you think about this?

I would like for this RHP screen for Hold to work the same whether it's 1 transaction or bulk transactions, so I think I would create a new PR for this tomorrow, once we agree on a solution.

OSBotify · 2024-07-03T20:01:45Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2024-07-04T15:18:56Z

@Kicu that's an issue and I agree that we should use the same page for all these actions. I think we could either go the Onyx route or React context to keep this in state since it doesn't really need to be persisted. Maybe creating a hook for it would be good, e.g. useSelectedItems or something like that.

OSBotify · 2024-07-04T22:14:12Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T11:01:08Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:20:41Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-08-05T16:31:36Z

src/components/SelectionList/Search/ReportListItem.tsx

                        showItemHeaderOnNarrowLayout={false}
                        containerStyle={styles.mt3}
                        isChildListItem
+                        isDisabled={!!isDisabled}
+                        canSelectMultiple={!!canSelectMultiple}
+                        isButtonSelected={item.isSelected}


there was a design issue Individually selected expense rows in grouped reports don't have a background color applied to them, we fixed it #45384 by checking transaction.isSelected instead of item.isSelected

WojtekBoman added 9 commits June 20, 2024 10:51

Add checkbox to search list items

da896c4

Handle disabling checkboxes

bf09dba

Handle selecting checkboxes in Search

1ed881d

Add template of SearchHeader

750768b

Add bulk actions to SearchActions

ebe5046

Fix TS in search list items components

a3de9b7

Refactor passing onCheckboxPress in BaseSelectionList

0614be1

Fix selecting report list items

3cd114a

Add translations

3edbdb1

luacmartins self-requested a review June 25, 2024 20:10

luacmartins reviewed Jun 25, 2024

View reviewed changes

src/libs/API/parameters/DeleteMoneyRequestOnSearchParams.ts Show resolved Hide resolved

rlinoz mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-24] [$250] [CSV] Add Selection mode to Search page #44577

Closed

WojtekBoman added 9 commits July 1, 2024 10:20

Merge branch 'main' into search/bulk-actions

b288a7c

Add translations, missing req params and clearing state

f832e43

Display no options available message

1c71750

Add isSelected prop to ActionCell

3638a40

Fix selecting checkboxes in ReportListItems

4f0a8e1

Add isButtonSelected prop

9023d74

Add SearchSelectionListWithHeader

93f2e50

Add missing docs to SelectedTransactionInfo

c4256e2

Fix types in DropdownOption

bcf6cbb

WojtekBoman marked this pull request as ready for review July 1, 2024 15:37

WojtekBoman requested a review from a team as a code owner July 1, 2024 15:37

melvin-bot bot removed the request for review from a team July 1, 2024 15:37

melvin-bot bot requested a review from DylanDylann July 1, 2024 15:37

WojtekBoman added 2 commits July 2, 2024 16:40

Add helper functions in SearchListWithHeader

aa22412

Disable dropdown button in SearchPageHeader when user is offline

e9d58ea

rayane-d approved these changes Jul 2, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins July 2, 2024 15:16

luacmartins previously approved these changes Jul 2, 2024

View reviewed changes

Merge branch 'main' into search/bulk-actions

4c82eac

WojtekBoman dismissed luacmartins’s stale review via 4c82eac July 2, 2024 19:21

luacmartins approved these changes Jul 2, 2024

View reviewed changes

luacmartins merged commit fe880cb into Expensify:main Jul 2, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

melvin-bot bot mentioned this pull request Jul 10, 2024

[$250] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Search v1] Add bulk actions #39887

Closed

WojtekBoman mentioned this pull request Jul 12, 2024

[Search] Display ConfirmModal before deleting expenses #45143

Merged

50 tasks

ishpaul777 reviewed Aug 5, 2024

View reviewed changes

ishpaul777 mentioned this pull request Aug 5, 2024

[HOLD for payment 2024-08-02] [$250] Individually selected expense rows in grouped reports don't have a background color applied to them #45190

Closed

6 tasks

hungvu193 mentioned this pull request Aug 19, 2024

[HOLD for payment 2024-08-19] [$250] Search - Select mode remains with empty state screen after deleting all expenses #46374

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search v1] Add bulk actions #44385

[Search v1] Add bulk actions #44385

WojtekBoman commented Jun 25, 2024 •

edited

Loading

luacmartins commented Jun 27, 2024

trjExpensify commented Jun 28, 2024

luacmartins commented Jun 28, 2024

trjExpensify commented Jun 28, 2024

melvin-bot bot commented Jul 1, 2024

WojtekBoman commented Jul 2, 2024

luacmartins commented Jul 2, 2024

luacmartins left a comment

luacmartins Jul 2, 2024

luacmartins Jul 2, 2024

luacmartins Jul 2, 2024

luacmartins commented Jul 2, 2024

WojtekBoman commented Jul 2, 2024

OSBotify commented Jul 2, 2024

Kicu commented Jul 3, 2024

Kicu commented Jul 3, 2024

OSBotify commented Jul 3, 2024

luacmartins commented Jul 4, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

ishpaul777 Aug 5, 2024

[Search v1] Add bulk actions #44385

[Search v1] Add bulk actions #44385

Conversation

WojtekBoman commented Jun 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins commented Jun 27, 2024

trjExpensify commented Jun 28, 2024

luacmartins commented Jun 28, 2024

trjExpensify commented Jun 28, 2024

melvin-bot bot commented Jul 1, 2024

WojtekBoman commented Jul 2, 2024

luacmartins commented Jul 2, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins Jul 2, 2024

Choose a reason for hiding this comment

luacmartins Jul 2, 2024

Choose a reason for hiding this comment

luacmartins Jul 2, 2024

Choose a reason for hiding this comment

luacmartins commented Jul 2, 2024

WojtekBoman commented Jul 2, 2024

OSBotify commented Jul 2, 2024

Kicu commented Jul 3, 2024

Kicu commented Jul 3, 2024

OSBotify commented Jul 3, 2024

luacmartins commented Jul 4, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

ishpaul777 Aug 5, 2024

Choose a reason for hiding this comment

WojtekBoman commented Jun 25, 2024 •

edited

Loading