sendAction deprecation

[josemarluedke]

Running ember-table with Ember v3.4 beta gave me the following deprecation:

DEPRECATION: You called <my-app@component:ember-tr::ember7583>.sendAction("onClick") but Component#sendAction is deprecated. Please use closure actions instead. [deprecation id: ember-component.send-action] See https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action for more details.

[pzuraq]

Unfortunately due to our support matrix (we support Ember 1.12+) we won’t be able to change this API until Ember Table v3. We should look to see if there is a way to suppress this deprecation until then.

[Alonski]

Isn't there a way to check what version the app is running and call functions accordingly?
Do closure actions and legacy actions at the same time somehow?

[pzuraq]

There is ember-compatability-helpers which would allow you to do that, happy to merge PRs but I won’t have time to continue working on this project for the forseeable future. Main thing that will be tricky is tests

[Alonski]

@pzuraq That looks interesting. If I find the time I will check it out. Thanks

[sanmaverick]

Are there any plans for fixing this in ember table v2?

[HeroicEric]

I believe this was fixed by #860, so this can probably be closed

[kpfefferle]

Resolved by #860