Remove sendAction API
#860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we are dropping support for older version of Ember.js, we need to make sure we trim the usage of old/deprecated APIs, as well. This time around it is the mechanism by which the actions are propagated, or
sendActionAPI.sendActionAPI has been deprecated in favour of closure actions seems like forever ago (Ember 2.0+ but do not quote me on that.)This PR makes sure we use only closure actions moving forward. It also contains a breaking change: the consumers that passed actions via a string (i.g.
onUpdateSorts="myAction") will have to change their code toonUpdateSorts=(action "myAction").This PR targets 3.0 release.
Closes #825
Closes #801
Related to #819
Known Actions
onSelectionToggledonClickonCollapseToggledonUpdateSortsonReorderonResizeonHeaderCellContextMenuonSelectonRowClickonRowDoubleClickonCellClickonCellDoubleClick