separate lifetimes from the parser and result version 2 #8
+507
−506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't forcefully tie them and clarify lookup_dataset works w/ 'static WootheeResults Closes woothee#6
pjenvey
force-pushed
the
separate-lifetime-parser-and-result2
branch
from
12b208d to
5c350f1
Compare
|
You could probably even make version a &'a str (tied to an agent: &'a str) with enough effort, since I think it's all derived from regex matches on agent |
|
@pjenvey LGTM
I see. I will also convert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hhatto, here's a long the lines of what I described in #6 (comment)
It seems removing the forceful tying of Parser lifetimes to WootheeResults and clarifying lookup_dataset dealt with 'static WootheeResults was all that was needed
(diff against 83e1979 to see what I mean)
Closes #6