Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WootheeResult lifetimes needlessly tied to Parser's #5

Closed
pjenvey opened this issue Jan 25, 2018 · 2 comments
Closed

WootheeResult lifetimes needlessly tied to Parser's #5

pjenvey opened this issue Jan 25, 2018 · 2 comments
Assignees

Comments

@pjenvey
Copy link
Contributor

pjenvey commented Jan 25, 2018

Parser's an empty struct without any state. Lifetime expansion causes WootheeResult's 'a lifetime to correspond to Parser's. This doesn't really make any sense and inconveniences the API.

I'd think the strings contained in WootheeResult should likely all be 'static or at the very least tied to the agent &str (if slices are pulled from it).

Here's an example and further discussion:

https://stackoverflow.com/questions/42564300/return-struct-with-lifetime-for-ffi/42564847

@pjenvey
Copy link
Contributor Author

pjenvey commented Feb 13, 2018

See my comment in #6 (comment)

@pjenvey
Copy link
Contributor Author

pjenvey commented Apr 30, 2018

closed w/ #6, #8

@pjenvey pjenvey closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants