-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option :migrations-table-exists-sql
for SQL backed migrations
#158
Add option :migrations-table-exists-sql
for SQL backed migrations
#158
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
8e86a41
to
e247bfd
Compare
Implemented the same thing in @weavejester Let me know what you think. Especially about the comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated PR. Can you ensure all lines are 80 characters or less?
Updated as per comments. Thanks for looking into this. 😄
Done. Although, there are some prior lines not respecting it.
|
Ping 😄 |
Apologies for the delay, this PR seems to have slipped through my inbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor formatting suggestions. Once they're done could you squash down your commits and give them an appropriate commit message. Once again, apologies for not getting around to reviewing this.
4f8048c
to
04668be
Compare
Done! Thanks for looking at this. 😄 |
Thanks! Can you change the commit message to:
This is to ensure it adheres to the contributing guidelines. Once that's done I'll merge and cut a release. Thanks again for your patience. |
Add a :migrations-table-exists-sql option in order to more efficiently check for the Ragtime migrations table. Using database metadata lookups via JDBC can be slow depending on the size of the database. Fixes weavejester#157.
04668be
to
120b75b
Compare
Done! Thanks! |
Closes #157