Add option to support DBs with non-uniform catalog table name #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. Can you ensure it aligns with the |
DatabaseMetaData.getTables expects a recognized table type identifier as 5th parameter. This is one of the entries from .getTableTypes, and likely but not necessarily "TABLE". E.g. DuckDB uses "BASE TABLES", so with "TABLE" hardcoded, migration fails because ensure-migrations-table-exists always tries to recreate the migration table.
|
@weavejester this should be better? |
|
My thought is that with #158 merged, we no longer need this option, as databases with non-standard catalog names can be checked with a custom SQL query instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseMetaData.getTables expects a recognized table type identifier as 5th parameter. This is one of the entries from .getTableTypes, and likely but not necessarily "TABLE". E.g. DuckDB instead uses "BASE TABLES", https://duckdb.org/docs/sql/information_schema,
and consequently ensure-migrations-table-exists fails during migration. This commit adds an additional key to the options map to SqlDatabase, allowing customization of this table type name, with a default of "TABLE".