Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: attempt to make Vite websocket tests more reliable (#21078) (CP: 24.7) #21088

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

Copy link

github-actions bot commented Mar 6, 2025

Test Results

1 169 files  1 169 suites   1h 15m 2s ⏱️
7 778 tests 7 721 ✅ 57 💤 0 ❌
8 144 runs  8 078 ✅ 66 💤 0 ❌

Results for commit aefb4b7.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati marked this pull request as draft March 6, 2025 09:33
auto-merge was automatically disabled March 6, 2025 09:33

Pull request was converted to draft

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

The JDK HttpServer uses the common Fork Join pool to fullfill callbacks
connected to async operations, like the websocket connection handshake.
On GH actions sometimes the callbacks are executed with a delay of a couple
of seconds, most likely caused by many tests running in parallel on the same
JVM and concurently submitting mid/long running tasks to the common pool.
This change increases the ViteWebsocketConnection timeouts to take
care of such delays.
@mcollovati mcollovati force-pushed the cherry-pick-21078-to-24.7-1741250502669 branch from 1312f8b to aefb4b7 Compare March 6, 2025 12:59
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

Copy link

sonarqubecloud bot commented Mar 6, 2025

@mcollovati mcollovati marked this pull request as ready for review March 6, 2025 14:06
@mcollovati mcollovati merged commit c1ef384 into 24.7 Mar 6, 2025
26 checks passed
@mcollovati mcollovati deleted the cherry-pick-21078-to-24.7-1741250502669 branch March 6, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants