test: increase timeouts for ViteWebsocketConnection tests #21093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JDK HttpServer uses the common Fork Join pool to fullfill callbacks connected to async operations, like the websocket connection handshake. On GH actions sometimes the callbacks are executed with a delay of a couple of seconds, most likely caused by many tests running in parallel on the same JVM and concurently submitting mid/long running tasks to the common pool. This change increases the ViteWebsocketConnection timeouts to take care of such delays.
caalador
approved these changes
Mar 6, 2025
|
mcollovati
deleted the
test/vitewebsocketconnectiontest-increase-timeouts
branch
mcollovati
added a commit
that referenced
this pull request
Mar 6, 2025
The JDK HttpServer uses the common Fork Join pool to fullfill callbacks connected to async operations, like the websocket connection handshake. On GH actions sometimes the callbacks are executed with a delay of a couple of seconds, most likely caused by many tests running in parallel on the same JVM and concurently submitting mid/long running tasks to the common pool. This change increases the ViteWebsocketConnection timeouts to take care of such delays.
mcollovati
added a commit
that referenced
this pull request
Mar 6, 2025
The JDK HttpServer uses the common Fork Join pool to fullfill callbacks connected to async operations, like the websocket connection handshake. On GH actions sometimes the callbacks are executed with a delay of a couple of seconds, most likely caused by many tests running in parallel on the same JVM and concurently submitting mid/long running tasks to the common pool. This change increases the ViteWebsocketConnection timeouts to take care of such delays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JDK HttpServer uses the common Fork Join pool to fulfill callbacks connected to async operations, like the websocket connection handshake. On GH actions, sometimes the callbacks are executed with a delay of a couple of seconds, most likely caused by many tests running in parallel on the same JVM and concurrently submitting mid/long running tasks to the common pool. This change increases the ViteWebsocketConnection timeouts to take care of such delays.