Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ShowUnroutableContentWarnings to V13 #18479

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Feb 26, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

#17837 introduced a configuration option (ShowUnroutableContentWarnings) to disable warnings for unroutable content in V15 (the warnings were originally introduced for V13 in #17705).

This PR backports the same configuration from V15 to V13 😄

Testing this PR

  1. Create content with conflicting routes.
  2. Verify that warnings are conditionally displayed at publish time for that content, depending on the current value of ShowUnroutableContentWarnings

Note that you must have ShowDomainWarnings disabled to reliably test this, because ShowDomainWarnings overrules ShowUnroutableContentWarnings in certain scenarios:

"Umbraco": {
    "CMS": {
      "Content": {
        "ShowDomainWarnings": false,
        "ShowUnroutableContentWarnings": true/false
      }

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this by creating two content items with the same route using the umbracoUrlName magic property. Can confirm the warning only appears when configured to do so.

Just to note, we've missed documenting this for 15, but I've included now in this PR for 15.3: umbraco/UmbracoDocs#6879

As well as this one for 13.8: umbraco/UmbracoDocs#6876

@AndyButland AndyButland merged commit 5ed09eb into v13/dev Feb 26, 2025
19 of 20 checks passed
@AndyButland AndyButland deleted the v13/feature/backport-unroutable-content-config branch February 26, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants