Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Warn when content is unroutable #17837

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Dec 18, 2024

Notes

  • This is a v15 implementation of Warn about un-routable content at publish time #17705
  • We had to refactor DocumentUrlService to not use the cache, as when we're getting the ContentPublishedNotification notification, the cache is still not updated with the correct URL, and thus this didn't work.

How to test

  • Follow steps in original PR

@Zeegaan Zeegaan requested a review from kjac January 6, 2025 10:07
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💪

Note that since the "new" backoffice is a lot less tightly coupled to the API controllers, we can't replicate the exact V13 behaviour. Effectively this means that there will be double warnings if both "domain warnings" and "unroutable content warnings" are triggered.

If this becomes a problem down the line, we'll have to refine the notifications system or maybe combine both warnings into one single notification handler.

@Zeegaan Zeegaan merged commit e5e5e8c into v15/dev Jan 8, 2025
26 of 27 checks passed
@Zeegaan Zeegaan deleted the v15/feature/implement-#17705 branch January 8, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants