Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance measuring code bug #313

Merged

Conversation

haalogen
Copy link
Contributor

@haalogen haalogen commented Feb 16, 2019

Change argument of this.callbacks.visitingCallback()
Issue: #312

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@haalogen haalogen marked this pull request as ready for review February 16, 2019 20:43
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #313   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         147    147           
  Lines        2591   2591           
  Branches      432    432           
=====================================
  Hits         2591   2591
Impacted Files Coverage Δ
.../algorithms/sorting/quick-sort/QuickSortInPlace.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f39355...22be348. Read the comment docs.

@trekhleb trekhleb merged commit b87e326 into trekhleb:master Mar 8, 2019
shoredata pushed a commit to shoredata/javascript-algorithms that referenced this pull request Mar 28, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@haalogen haalogen deleted the haalogen-patch-1-QuickSortInPlace branch April 4, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants