Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickSortInPlace: bug in performance measuring code. #312

Closed
haalogen opened this issue Feb 16, 2019 · 1 comment
Closed

QuickSortInPlace: bug in performance measuring code. #312

haalogen opened this issue Feb 16, 2019 · 1 comment

Comments

@haalogen
Copy link
Contributor

haalogen commented Feb 16, 2019 •
edited
Loading

Hey guys,

javascript-algorithms/src/algorithms/sorting/quick-sort/QuickSortInPlace.js

Line 49 in 1f39355

this.callbacks.visitingCallback(array[pivot]);

pivot is meant to be a value, isn't it?
Shouldn't it be

 this.callbacks.visitingCallback(array[highIndex]);

or

 this.callbacks.visitingCallback(pivot);

instead?

This change is also proposed in: #239
@haalogen haalogen mentioned this issue Feb 16, 2019
Merged
@trekhleb
Copy link
Owner

trekhleb commented Mar 8, 2019

@haalogen yes, you're right. Thank you for the fix!

@trekhleb trekhleb closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haalogen @trekhleb