Refactor QuickSortInPlace #239
Open
+43
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sort in place without copying the orignal input * Remove `recursiveCall` param from `sort` method as not needed anymore * Extract `partitionArray` function to class method * Remove `swap` function - use destructuring instead * Call `visitingCallback` with the right arguments - in this case with `pivot`
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 143 143
Lines 2552 2545 -7
Branches 422 421 -1
=====================================
- Hits 2552 2545 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recursiveCallparam fromsortmethod as not needed anymorepartitionArrayfunction to class methodswapfunction - use destructuring insteadvisitingCallbackwith the right arguments - in this case withpivot