[email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA #532

mindlapse · 2019-08-30T21:02:26Z

Merge of the experimental branch onto master for the 8.0.0 release

AppInfo is needed so that Stripe can identify the transactions that are created through tipsi-stripe Along with this, the compile and target SDK versions for android have been bumped to v28, stripe-android has been upgraded to 9.3.5, the minSdkVersion has increased to v19 (required). Example app changes: - Android compile and target SDK change from 26 -> 28 - Android min SDK change from 16 -> 19 - Android multiDexEnabled true - Android support libraries upgraded to v28 - React native upgraded to 0.59.10 - React upgraded to 16.8.6 - android.useDeprecatedNdk=true was removed since it is no longer supported. - android.enableAapt2=false was removed since it is now the default - Gradle build tools upgraded to 3.4.1. Gradle wrapper upgraded to v5.5.

- CircleCI config (for android) - Android - Compile SDK version increased from 26 to 28 - Android - Target SDK version increased from 26 to 28 - Android - Min SDK version increased from 16 to 19 - Android - stripe-android increased from 8.1.0 to 9.3.5 - Android - Added Stripe AppInfo to requests Example app: - Updated react-native to 0.59.10 from 0.45.0 - Updated react to 16.8.6 from 16.0.x - Upgraded gradle Tests: - Updated test suite to use webdriver 5.x from 4.7.1 - Update appium to 1.14

…tion guide.

…he requiredBillingAddressFields-option

…ocumentation

… in the codebase

…and render the current docs

Note: This commit breaks iOS - a subsequent commit is needed Added confirmPayment, authenticatePayment, createPaymentMethod bindings for src/Stripe.js Upgrade to stripe-android:10.1.1

Note: This commit breaks iOS - a subsequent commit is needed

…ive-pay

- Confirmation of a payment intent resolves with { status, paymentIntentId } - status is one of 'CANCELED', 'FAILED', 'SUCCEEDED', 'TIMEDOUT', or 'UNKNOWN' - test page requires 'STRIPE_BACKEND' env to be defined, and it should contain a URL with a trailing slash pointing to a deployment of https://github.com/mindlapse/example-tipsi-stripe-backend

Wiring in the new example app PaymentIntentScreen

…t fix)

…ive-pay

… widget

vpontis · 2020-01-14T20:27:11Z

I build and published the docs folder in this branch: https://tipsi-stripe-8-0-docs.onrender.com/ as of commit 10026e9

The docs are missing some of the new methods, so they aren't complete. But maybe this is helpful to other people looking at this PR :)

[iOS] Fix extracting billingDetails

…_ios_with_8.0.0.beta9 Bugfix/fix compilation error on ios for 8.0.0.beta9

See stripe/stripe-ios#1526

Stripe Connect Support: Add setStripeAccount.

bramski · 2020-07-29T00:37:00Z

@fbartho @mindlapse Where are we at with getting this merged? Looks like a whole bunch of conflicts and I'm guessing broken tests. I must update our app to AndroidX and keep the SCA and stripe-connect support.

Should I take up the flame here, fix the tests and the conflicts? Then can we get this merged and move forward with AndroidX support?

cybergrind · 2020-07-29T13:50:27Z

@bramski tests don't work for a long time, there is an semi-active branch called experimental and we're releasing a beta version that is used by some teams and has reasonable stability for production needs.
To get experimental branch merged into master we need to get some automatic tests or team that will do manual testing on a regular basis. Unfortunately, Tipsi team isn't here anymore and the company was merged twice and don't use RN anymore.

bramski · 2020-07-29T16:01:48Z

@cybergrind Yup I get that. We've been using the experimental branch now for 1 year since SCA became a requirement in europe. So I'm quite happy with the branch. What I'd like to know is where to get started to fix the tests. I need to make a choice whether to fix or ditch this library. I don't think we can very well ditch stripe so I need to estimate for our project how much work is needed to bring this library up to snuff and get it working on RN 0.6x. There is separate work for AndroidX and I need the experimental work. I'd much prefer to get this branch fixed and merged so we can move forward with active development. I believe the SCA work to be stable at this point, but the tests should be fixed to be of value for this project.

bramski · 2020-07-29T16:18:37Z

android/src/main/java/com/gettipsi/stripe/Errors.java

+    if (errorCode == null) {
+      errorCode = simpleName;
+    }
+//    ArgCheck.nonNull(errorCode, simpleName);


Seems like it would be better just to delete this. This should definitely be non-null at this point as .getSimpleName will always return non-null.

bramski · 2020-07-29T16:20:13Z

android/src/main/java/com/gettipsi/stripe/util/Converters.java

+    wm.putString("status", intent.getStatus().toString());
+    wm.putString("paymentIntentId", intent.getId());
+
+//    String paymentMethodId = intent.getPaymentMethodId();


Seems like this comment should be deleted. The code above covers it.

fbartho · 2020-07-29T18:00:14Z

@bramski -- let's discuss in Discord!

Clonescody · 2020-09-08T15:46:30Z

Any update on this guys ?

fbartho · 2020-09-08T17:59:26Z

@Clonescody -- you should think of the experimental branch as the new trunk for development for tipsi-stripe >= 8.0.0 -- all the contents of this PR have been deployed with the latest release: [email protected] and has been in production for many people for months now.

* Fix payment method address * Fix Stripe billing address type

Co-authored-by: Jeremias Binder <[email protected]>

bramski · 2020-12-25T22:57:02Z

Did you guys merge this to master? Why has it been closed?

…

On Fri., Dec. 25, 2020, 2:46 a.m. Kirill Pinchuk, ***@***.***> wrote: Closed #532 <#532>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADG7FNVF4RXZLXXOGJLG4LSWRUR3ANCNFSM4ISRENZQ> .

varemenos · 2020-12-26T01:13:54Z

Seems like it's been deprecated in favor of the Stripe-RN efforts.

Please don't use this library anymore

Stripe team finally has decided to provide RN binding themselves you can Apply Here

So Long, and Thanks for All the Fish!

From the README of the recently merged commit in master.

bramski · 2020-12-26T06:00:52Z

It's an interest form and they're not yet providing a solid RN API by which I could actually move our project to their API in any known timeframe. I bet we will continue to use tipsi-stripe for another 6 months to a year. So I find your closing of all issues here rather premature. It won't help people still using this codebase to find all the issues closed. I am quite happy to see this move forward by stripe given the status of this codebase though. Thanks for the efforts that were done here. Cheers.

…

On Fri., Dec. 25, 2020, 5:14 p.m. Adonis Kakoulidis, < ***@***.***> wrote: Seems like it's been deprecated in favor of the Stripe-RN efforts. Please don't use this library anymore Stripe team finally has decided to provide RN binding themselves you can Apply Here So Long, and Thanks for All the Fish! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADG7FOZ47FTJIZCWEIOVNDSWU2F3ANCNFSM4ISRENZQ> .

cybergrind · 2020-12-27T10:42:49Z

Hey @bramski

It's an interest form, and they're not yet providing a solid RN API

As I understand, they actually have a team working on the new library and can access it. I'm not sure why it is behind the wall.

I find your closing of all issues here rather premature.

The library itself isn't going anywhere. I want to encourage everyone to move forward to Stripe's official library.

Personally, I hate the "maintaining" project with 200 issues and dozens of PRs without any chance to get decent resources to work on it.
This library is a part of the intellectual property of Tipsi => Bridge => SevenFifty, and I'm not part of the team for 2 years. And business owners don't want to donate it to the community, + no one wanted to create hard-fork of it.

I would continue this only if we had people that can actually fix CI. Primarily because I'm no longer using RN.
Fortunately, we have community members that want to improve the library itself.

Unfortunately, we don't have anyone who would fix CI or anyone who would sponsor this work. Probably we could try to raise this money and do everything in hard-fork but, if Stripe want to fund their own library, it would be better for all of us

mindlapse and others added 30 commits July 5, 2019 11:21

Adding .circleci

19c3f8c

stripe-ios AppInfo initial config

26902bd

managedAccountCurrency is no longer relevant according to the migra…

a3c76f2

…tion guide.

typo-fixes

82a00a3

Update Stripe CardForm options to support the "name"-only option in t…

1483850

…he requiredBillingAddressFields-option

Dynamically list supported ApplePay networks on this device & write d…

4b62ea2

…ocumentation

Switch eslint-config & allow rules that are already existing patterns…

e3ef588

… in the codebase

Add missing docs pages, and reorganize the sidebars a little bit

9df384f

Add prettier to format the rendered-docs-html making diffing easier, …

a55c4db

…and render the current docs

Upgrade Example Project to Stripe 16 & Cocoapods changed something

20b5cf7

misc test fix

a4c5ca5

React-Native 59 for the Example App for iOS

a588ed6

ApplePay example tweaks now that it's running

15320e2

Got the testapp changes working!

8d5f244

Prettier Javascript Formatting

dff3001

Extract Deprecated Methods to a separate file

ab6efce

Adds Android confirmPayment, authenticatePayment, createPaymentMethod

ad6f9c6

Note: This commit breaks iOS - a subsequent commit is needed Added confirmPayment, authenticatePayment, createPaymentMethod bindings for src/Stripe.js Upgrade to stripe-android:10.1.1

Adds Android confirmSetupIntent and authenticateSetup

6625d21

Note: This commit breaks iOS - a subsequent commit is needed

Merge remote-tracking branch 'tipsi/experimental' into fb/unified-nat…

272a49b

…ive-pay

Android changes for confirming a payment intent, with test page (cont..)

feb1e03

Wiring in the new example app PaymentIntentScreen

Prettier configs in subfolders

6c9d49c

Prettier Formatting

f14ea10

Adds SetupIntentScreen and stripe-android:10.2.1 (contains setupinten…

11b478e

…t fix)

Merge remote-tracking branch 'tipsi/experimental' into fb/unified-nat…

eec9088

…ive-pay

PaymentIntent demo page updated to include manual entry with the card…

68956ee

… widget

Add some jsDocs

d3b9f89

TPSCardField fixes

ad84efb

fbartho and others added 7 commits February 21, 2020 12:48

Merge pull request #592 from maxhungry/fix-ios-billing-details

7f49fc2

[iOS] Fix extracting billingDetails

Fixed compilation error for 8.0.0.beta9 due to fpx issue

d9e9eb4

Mark an unsupported entry with a comment

f0c48c0

Merge pull request #628 from guanhuay/bugfix/fix_compilation_error_on…

529f7d4

…_ios_with_8.0.0.beta9 Bugfix/fix compilation error on ios for 8.0.0.beta9

Fix build on xcode 11.4

2edbd84

See stripe/stripe-ios#1526

Merge pull request #563 from bramski/experimental-connect

e8b0467

Stripe Connect Support: Add setStripeAccount.

Update npmignore

926fddf

cybergrind force-pushed the experimental branch from 3dbd62d to 926fddf Compare April 2, 2020 10:02

fbartho changed the title ~~8.0.0 stable release~~ [email protected] [in Beta] Jun 4, 2020

fbartho mentioned this pull request Jun 4, 2020

Stripe PaymentIntents #448

Closed

fbartho changed the title ~~[email protected] [in Beta]~~ [email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA Jul 21, 2020

bramski reviewed Jul 29, 2020

View reviewed changes

fbartho mentioned this pull request Sep 15, 2020

Google Wallet / Native Payment -- stripe-android breaking changes! #683

Closed

maxhungry and others added 2 commits October 2, 2020 12:07

Fix billing address (#640)

6f469e1

* Fix payment method address * Fix Stripe billing address type

fix translation (#698)

4e3eff1

Co-authored-by: Jeremias Binder <[email protected]>

cybergrind force-pushed the master branch from bc8176d to 9f60a23 Compare December 25, 2020 10:19

cybergrind added the wont-fix label Dec 25, 2020

cybergrind closed this Dec 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA #532

[email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA #532

mindlapse commented Aug 30, 2019

vpontis commented Jan 14, 2020

bramski commented Jul 29, 2020

cybergrind commented Jul 29, 2020

bramski commented Jul 29, 2020

bramski Jul 29, 2020

bramski Jul 29, 2020

fbartho commented Jul 29, 2020

Clonescody commented Sep 8, 2020

fbartho commented Sep 8, 2020

bramski commented Dec 25, 2020 via email

varemenos commented Dec 26, 2020 •

edited

Loading

bramski commented Dec 26, 2020 via email

cybergrind commented Dec 27, 2020

[email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA #532

[email protected] [in Beta] - PaymentIntents, SetupIntents & 3DSecure2 / SCA #532

Conversation

mindlapse commented Aug 30, 2019

vpontis commented Jan 14, 2020

bramski commented Jul 29, 2020

cybergrind commented Jul 29, 2020

bramski commented Jul 29, 2020

bramski Jul 29, 2020

Choose a reason for hiding this comment

bramski Jul 29, 2020

Choose a reason for hiding this comment

fbartho commented Jul 29, 2020

Clonescody commented Sep 8, 2020

fbartho commented Sep 8, 2020

bramski commented Dec 25, 2020 via email

varemenos commented Dec 26, 2020 • edited Loading

bramski commented Dec 26, 2020 via email

cybergrind commented Dec 27, 2020

varemenos commented Dec 26, 2020 •

edited

Loading