This repository was archived by the owner on Jan 3, 2024. It is now read-only.
[iOS] Fix extracting billingDetails #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aganov
added a commit
to appsbakery/tipsi-stripe
that referenced
this pull request
Dec 22, 2019
[iOS] Fix extracting billingDetails tipsi#592 AndroidX support for RN 0.60 or newer tipsi#598 remove rnpm usage tipsi#557 Added safeExtGet to build.gradle Added minSdkVersion = safeExtGet("minSdkVersion", 19) Added googlePlayServicesVersion = safeExtGet("googlePlayServicesVersion", "18.0.0") Removed com.google.firebase:firebase-core Bumped stripe-android to v10.4.6
fbartho
approved these changes
Feb 21, 2020
This was referenced Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix an iOS typo that prevents extracting the correct key and sending billing details to Stripe.
Types of changes
What types of changes does your code introduce to
tipsi-stripe?Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered.