Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support module-style 2-argument includes #672

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

ianatol
Copy link
Contributor

@ianatol ianatol commented Feb 19, 2022

Fixes #670

CC: @aviatesk

@timholy
Copy link
Owner

timholy commented Feb 19, 2022

WIP as the test gives UndefVarError: B670 not defined

You get the same error if you execute this without Revise, no? (Just from the julia prompt.) I don't think we support running additional commands after close-of-module when precompiling a package.

Perhaps try adding an internal module to B670 and then execute this as Base.include(Internal, ...) from within B670.

@ianatol ianatol changed the title WIP: Support module-style 2-argument includes Support module-style 2-argument includes Feb 23, 2022
@timholy
Copy link
Owner

timholy commented Mar 1, 2022

From my reading, your test doesn't use the 2-argument form of include in code that Revise sees. Calling it from within the test code directly isn't visible to Revise.

@timholy timholy merged commit 5845b09 into timholy:master Mar 7, 2022
@timholy
Copy link
Owner

timholy commented Mar 7, 2022

Thanks, @ianatol!

@ianatol
Copy link
Contributor Author

ianatol commented Mar 7, 2022

Thanks for the help along the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise gives MethodError on "module" 2-argument includes
2 participants