Revise gives MethodError on "module" 2-argument includes

[ianatol]

The include(mapexpr, path) case is discussed at #634, but similarly, Revise can't handle include(m::Module, path) either.

See JuliaLang/julia#43800 (comment) for an example.

For the module case, I tried the naive fix of modifying methods_by_execution as follows:

elseif skip_include && (f === modinclude || f === Base.include || f === Core.include)
                    # include calls need to be managed carefully from several standpoints, including
                    # path management and parsing new expressions
                    mod_or_path = @lookup(frame, stmt.args[2])
                    if isa(mod_or_path, Module) # include(mod, pathname)
                        add_includes!(methodinfo, mod_or_path, @lookup(frame, stmt.args[3]))
                    else
                        add_includes!(methodinfo, mod, mod_or_path)
                    end
                    assign_this!(frame, nothing)  # FIXME: the file might return something different from `nothing`
                    pc = next_or_nothing!(frame)

This passes Revise tests but doesn't seem to correctly give Revise access to the names from the include, as we hit a UndefVarError in the EscapeAnalysis example above. Will update if I can fix later today!

[timholy]

I'll get to this after the Julia 1.8 feature freeze. Bump this if I don't.

[ianatol]

Bumping, and on second thought I think my solution might work. There were other problems in the EA case that led to the UndefVarError, so this naive approach might actually be correct..

If you can't get around to it, I'll try and figure out how to write a test and open a PR based on this solution tomorrow.