Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise react-helmet-async instead of react-helmet #857

Conversation

jamessspanggg
Copy link
Contributor

@jamessspanggg jamessspanggg commented Nov 16, 2020

Fixes #856

Solution taken from: nfl/react-helmet#548

Acc No: c54c04774efaae20746fd3f29cdd619fea512e119bc1082b863572b2e8844104

@thesanjeevsharma
Copy link
Contributor

thesanjeevsharma commented Nov 16, 2020

@jamessspanggg I checked your solution, it solves the issue but it also introduced another bug.

When I go to any route for the first time, the title changes. But after that no matter how many routes I change, the title doesn't change at all. It always shows the title of the first page I visited.

Just try navigating to different pages and notice title.

@jamessspanggg
Copy link
Contributor Author

@jamessspanggg I checked your solution, it solves the issue but it also introduced another bug.

When I go to any route for the first time, the title changes. But after that no matter how many routes I change, the title doesn't change at all. It always shows the title of the first page I visited.

Just try navigating to different pages and notice title.

My bad, fixed it. I moved the Provider out to the App component.

@lakbychance lakbychance merged commit df71821 into thenewboston-blockchain:development Nov 16, 2020
@RajputUsman RajputUsman added PR / 1 / 1000 1 story point (easy / few hours - 1/2 day) Paid labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paid PR / 1 / 1000 1 story point (easy / few hours - 1/2 day)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNSAFE_componentWillMount console error
4 participants