Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNSAFE_componentWillMount console error #856

Closed
jamessspanggg opened this issue Nov 16, 2020 · 0 comments · Fixed by #857
Closed

UNSAFE_componentWillMount console error #856

jamessspanggg opened this issue Nov 16, 2020 · 0 comments · Fixed by #857
Labels
engineering Paid PR / 1 / 1000 1 story point (easy / few hours - 1/2 day)

Comments

@jamessspanggg
Copy link
Contributor

Bug Description
A clear and concise description of what the bug is.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run TNB in local dev
  2. Open the website's console
  3. Observe the console error

Expected behavior
No console error should appear.

Actual behavior
Console error as shown below in the screenshot.

Screenshots/Recordings
Screen Shot 2020-11-16 at 4 21 50 PM

OS and Browser

  • OS: Mac, Chrome or Safari

Additional context
I have looked through to find a solution, and it seems that there is a problem with using react-helmet. We should utilise react-helmet-async instead. More info here: nfl/react-helmet#548

Account Number
c54c04774efaae20746fd3f29cdd619fea512e119bc1082b863572b2e8844104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering Paid PR / 1 / 1000 1 story point (easy / few hours - 1/2 day)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilise react-helmet-async instead of react-helmet jamessspanggg/Website-1
3 participants
@lakbychance @jamessspanggg @RajputUsman