2023 11 21 datamodel corrections #8
Conversation
sjib
commented
Nov 21, 2023
•
sjib
commented
- Integrates latest datamodel changes from DSS_2020_1_LV95 - see https://www.vsa.ch/models/?dir=2020_1
- Integrates changes requestes from renaming of attributes #5
- Adds :SRID
- small formatting changes
Integrate latest changes in VSA-DSS 2020.1 and solve #5 Add :SRID
Integrate latest datamodel changes from 2020.1 and corrections Cyril. Add :SRID
for more information, see https://pre-commit.ci
…/teksi/wastewater into 2023-11-21-datamodel_corrections
for more information, see https://pre-commit.ci
…/teksi/wastewater into 2023-11-21-datamodel_corrections
ALTER TABLE tww_od.data_media ADD COLUMN path TEXT; Co-authored-by: Denis Rouzaud <[email protected]>
|
Ready to merge |
| @@ -169,7 +169,7 @@ COMMENT ON COLUMN tww_od.data_media.identifier IS 'yyy_Name des Datenträgers. B | |||
| COMMENT ON COLUMN tww_od.data_media.kind IS 'Describes the type of data media / Beschreibt die Art des Datenträgers / Décrit le genre de support de données'; | |||
| ALTER TABLE tww_od.data_media ADD COLUMN location varchar(50) ; | |||
| COMMENT ON COLUMN tww_od.data_media.location IS 'Location of the data medium / Ort, wo sich der Datenträger befindet / Emplacement du support de données'; | |||
| ALTER TABLE tww_od.data_media ADD COLUMN path varchar(1023) ; | |||
| ALTER TABLE tww_od.data_media ADD COLUMN path TEXT; | |||
There was a problem hiding this comment.
Can you explain this change? This field should be not longer than 1023 - else it is not a valid URI anymore.
There was a problem hiding this comment.
For such large fields, I would be in favor of having a constraint (db or client) instead. It is then easier for the user to understand why it is blocking and give the user some context.
Using a db defined field size could in some cases just truncate their content.
But if that's an issue I can live with both since there's not so much difference :
https://stackoverflow.com/questions/4848964/difference-between-text-and-varchar-character-varying
There was a problem hiding this comment.
Discussion about implementation length restrictions see #10
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Moved discussion to issue : |
