Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wastewater structure symbology trigger #68

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Remove wastewater structure symbology trigger #68

merged 6 commits into from
Jan 23, 2024

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Jan 9, 2024 •
edited
Loading

Tackles #66

  • removed from extensions
  • removed from symbology functions
  • altered in main views
  • altered swmm views

@3nids 3nids requested a review from sjib January 23, 2024 08:52
@sjib
Copy link
Contributor

sjib commented Jan 23, 2024

@urskaufmann Ist das gut so?
Musst du damit noch etwas im Projekt anpassen, da es damit in vw_tww_reach _usage_current und _function_hierarchic nicht mehr gibt - oder nimmt es automatisch die Felder die vorhanden sind?

https://github.com/teksi/wastewater/blob/e555f19c49bec0654b5625c9c6c2905632fec1a5/datamodel/app/view/vw_tww_reach.py

Gleiche Frage für vw_tww_wastewater_structure.

sjib
sjib approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked together with @urskaufmann - ok to merge

@3nids 3nids merged commit 6bee96b into teksi:main Jan 23, 2024
@cymed cymed deleted the remove_ws_symbology_triggers branch January 23, 2024 12:11
@cymed cymed mentioned this pull request Feb 20, 2024
Closed
3 tasks
@cymed cymed mentioned this pull request Feb 27, 2024
Merged
@ponceta ponceta added enhancement New feature or request datamodel Concerns the datamodel labels Mar 13, 2024
cymed added a commit to cymed/TEKSI-wastewater that referenced this pull request Aug 30, 2024
@cymed
revert altering creation scripts
5e64a5d 
valid scripts will be in teksi#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjib sjib sjib approved these changes

Assignees

@cymed cymed

Labels
datamodel Concerns the datamodel enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cymed @sjib @3nids @ponceta