-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 08 05 import export re maintenance event #357
Conversation
|
|
|
In QGIS it takes quite some time to open the table and it then does not display all identifiers (in the fk_wastewater_structure) column: @urskaufmann Does it makes sense to try to find the identifier in this table? |
I also get tons of these warnings:
|
Testing export:
|
|
|
I think no |
export seems to work with re_buidling_group_disposal. |
On import we do not check if combination fk_1 fk_2 is already in the table - as this cannot be checked with obj_id as in other tables
|
|
Tests with
So it does not find the cls
|
Import is working but CI generates an error
@domi4484 Do you see what would need to be adapted for re_tables? Die re_tabellen werden aufgrund dieser Association gebildet als Zwischentabellen für die Abbildung von n:m Beziehungen.
|
Datacheck in re_classes moved to new issue #365 Link table don't exists for KEK
c651e14
to
5d30aa5
Compare
5d30aa5
to
82e16e5
Compare
@domi4484 Thanks for the adaptions I will have a look at them. |
@sjib in principle the implementation is still yours, re_tables are implemented like all other tables. About the different models, the exception is for KEK that differs from TWW. During import/export we check if the current model is KEK and handle it accordingly. This are the concerned lines: For import it was already implemented here with the check For export it is done by testing the model to export here: |
There is still an issue with the export to DSS. In case a |
@domi4484 In 2015 the class This was corrected in 2020 and later and data is only allowed in the now 3 subclasses from maintenance_event ( So you have to consider that and adapt the code and not support the old way that was implemented in qgep in tww. So if you import data from VSA-KEK 2020.1 you have always an entry in examination and damages are then connected to this. Hope this helps you understand and fix the last bugs. |
I guess with that all the complicate checking if an fk_ exists might be obselet. |
@sjib The issue remains, because when we iterate over the content of So my best idea at the moment is to query the |
@domi4484 Go ahead with that - I don't have experience Don't know if this could be helpful for the future: http://docs.sqlalchemy.org/en/latest/orm/inheritance.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to coment what is the difference between
- Test on QGIS
- Test on QGIS DSS dataset
General
Describe your changes
Should solve #352
Screenshots
Issue ticket number and link
Checklist before requesting a review
Checklist before merge