Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename symbology order attributes #353

Merged
merged 13 commits into from
Aug 27, 2024
Merged

Rename symbology order attributes #353

merged 13 commits into from
Aug 27, 2024

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Aug 5, 2024 •
edited by ponceta
Loading

General

  • Fix a bug
  • Maintenance / sustainability

Describe your changes

This PR does two things:

  1. It renames order_fct_hierarchic and order_usage_current in the corresponding value lists to tww_symbology_order to mark the field as a tww extension
  2. It removes hardcoded codes of these value lists from the symbology functions and replaces them with tww_symbology_order

Screenshots

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • CI Tests are green
  • The documentation is up to date with the proposed change.
  • My work is ready for review

Checklist before merge

  • A review has been performed
  • Comments are resolved
  • Documentation is ready

Edit by @ponceta 12.08.2024

@cymed cymed changed the title Do not hardcode usage_current and function_hierarchic in symbology functions Rename symbology order attributes Aug 7, 2024
@cymed cymed requested a review from ponceta August 7, 2024 08:18
@cymed cymed self-assigned this Aug 7, 2024
@cymed cymed added the datamodel Concerns the datamodel label Aug 7, 2024
@cymed cymed linked an issue Aug 9, 2024 that may be closed by this pull request
FUNCTION: tww_app.update_wastewater_structure_label has old code for rainwater instead of surfacewater #375
Closed
@cymed cymed mentioned this pull request Aug 9, 2024
Closed
@ponceta ponceta added fix Fixing something not working sustainability labels Aug 12, 2024
@cymed
Copy link
Contributor Author

cymed commented Aug 14, 2024

ready for review. New tests are not necessary as we have existing test for labelling

@ponceta ponceta closed this Aug 27, 2024
@ponceta ponceta reopened this Aug 27, 2024
@ponceta ponceta closed this Aug 27, 2024
@ponceta ponceta reopened this Aug 27, 2024
@ponceta

This comment was marked as off-topic.

Sign in to view
@ponceta

This comment was marked as resolved.

Sign in to view
@ponceta ponceta merged commit 7fa9b37 into teksi:main Aug 27, 2024
16 of 17 checks passed
@cymed cymed deleted the use-order-fct-hierarchic-in-output-order branch August 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

Assignees

@cymed cymed

Labels
datamodel Concerns the datamodel fix Fixing something not working sustainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FUNCTION: tww_app.update_wastewater_structure_label has old code for rainwater instead of surfacewater
2 participants
@cymed @ponceta