-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise error on subclass check #340
Conversation
for more information, see https://pre-commit.ci
@cymed Fix seems to work - only error message is wrong (change too many / too few). I have added one additional structure_part entry in my data. So I am missing a corresponding subclass entry. |
@cymed Should be adapted to And the other case: Is that clearer? |
Wouldn't it be too many subclass entries in Case 2? |
Yes, I think then it is right - either we have too many superclass entries or we have too many subclass entries. |
And in using superclass and subclass we indicate where to check |
I found out, that we also do the subclass check when we make a selection. For the user it is a little bit confusing to get the subclass check error also then even if the selected objects are correct.
I would stay with the existing behaviour an may be adjust the error message to not confuse the users. Any comments on that? |
Co-authored-by: Damiano Lombardi <[email protected]>
Solves #337
Not tested yet - thus draft PR