Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-07-11-interlis-import-fix-references-value-lists #304

Merged
merged 13 commits into from
Jul 12, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Jul 11, 2024

  • measuring_point - purpose & damming_device - treat as value lists as in data model definition

@sjib sjib added the bug Something isn't working label Jul 11, 2024
@sjib sjib added this to the TEKSI Wastewater 2024.0 milestone Jul 11, 2024
@sjib sjib self-assigned this Jul 11, 2024
@sjib
Copy link
Contributor Author

sjib commented Jul 11, 2024

to adapt: building_group

  • # fk_disposal=self.get_pk(row.entsorgungref__REL), # TODO check why not available
    Has to be matched to re_table

opened new issue 307 for this

@sjib
Copy link
Contributor Author

sjib commented Jul 11, 2024

  • maintenance_event.active_zone - old extension of qgep - not supported anymore in tww
            logger.warning(
                "TWW examination.active_zone has no equivalent in the interlis model. This field will be null."
            )

                # --- maintenance_event ---
                # active_zone=row.REPLACE_ME,  # TODO : found no matching field for this in interlis, confirm this is ok

@sjib
Copy link
Contributor Author

sjib commented Jul 11, 2024

  • Untersuchung - nicht mehr notwendig

    ```
        fk_operating_company=(
                  row.ausfuehrende_firmaref if row.ausfuehrende_firmaref else None
              ),
    

@sjib
Copy link
Contributor Author

sjib commented Jul 11, 2024

  • to correct vsa-kek 2020 - attributes moved to super class / einige attribute wurden in oberklasse verschoben

    def _import_schaden und kanalschaden und normschachtschaden anpassen

Updated 12.7.2024: Seems to work like this - but is not very logic as all attributes are handeled in the subclass. To check with @domi4484 why implemented like this. Opened a new issue 306.

@sjib
Copy link
Contributor Author

sjib commented Jul 12, 2024

@domi4484 Can you have a look and review on this and check also the newly created issues 306 and 307 and comment on them

@sjib sjib added fix Fixing something not working and removed bug Something isn't working labels Jul 12, 2024
@sjib
Copy link
Contributor Author

sjib commented Jul 12, 2024

Should solve #303

@ponceta ponceta self-requested a review July 12, 2024 13:33
@ponceta ponceta merged commit cb2858e into main Jul 12, 2024
4 checks passed
@ponceta ponceta deleted the 2024-07-11-interlis-import-fix-references-value-lists branch July 12, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants