Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label export orientation #281

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Jul 4, 2024

Up to now, the labels_orientation_offset is not passed to the function _modulo_angle in the intermediate schema.

This PR takes the changes from #217 and applies the following fixes:

  • tww:extractlabels_interlis has no Parameter "EXPORT_ORIENTATION". Parameter is dropped on export of labels. file.
  • On Export, the orientation offset is passed to the intermediate schema
  • Without this PR, the export of labels will not work

Up to now, the labels_orientation_offset is not passed to the function _modulo_angle in the intermediate schema.

This PR takes the changes from teksi#217 and applies the following fixes:

- tww:extractlabels_interlis has no Parameter "EXPORT_ORIENTATION". Parameter is dropped on export of labels. file.
- On Export, the orientation offset is passed to the intermediate schema
@cymed cymed added fix Fixing something not working INTERLIS About INTERLIS exchange format (import / export) labels Jul 4, 2024
@cymed cymed added this to the TEKSI Wastewater 2024.0 milestone Jul 4, 2024
@cymed cymed requested a review from sjib July 4, 2024 10:45
@cymed cymed self-assigned this Jul 4, 2024
@sjib sjib merged commit 3e39509 into teksi:main Jul 4, 2024
4 checks passed
@cymed cymed deleted the fix_label_export_orientation branch July 4, 2024 14:09
@sjib
Copy link
Contributor

sjib commented Jul 4, 2024

@cymed Herzlichen Dank!

Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working INTERLIS About INTERLIS exchange format (import / export)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants