Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vw_tww_maintenance should be vw_tww_maintenance_event #33

Closed
urskaufmann opened this issue Dec 3, 2023 · 4 comments · Fixed by #40
Closed

vw_tww_maintenance should be vw_tww_maintenance_event #33

urskaufmann opened this issue Dec 3, 2023 · 4 comments · Fixed by #40
Assignees

Comments

@urskaufmann
Copy link
Contributor

There are several problems with this vw:

  • name should be vw_tww_maintenance_event
  • it is now composed of superclass maintenance_event and subclass examination. The other subclasses are missing: maintenance (one field) and bio_ecol_assessment (17 fields).
  • the class_prefix for the fieldnames seems to be helapful in this case: EX for examination, BO for bio_ecol_assessment and MN for Maintenance (Unterhalt)
@sjib
Copy link
Contributor

sjib commented Dec 4, 2023

That is right!
There is a change between qgep (VSA-DSS 2015) and teksi_wastewater (VSA-DSS 2020).
vw_qgep_maintenance event cannot be just renamed to vw_tww_maintenance_event.

3 subclass views have to be newly designed as we have now three subclasses for maintenance_event and it is not allowed anymore to directly add data to the class maintenance_event (ABSTRACT), but only to the subclasses.

I suggest also to create 3 separate forms, depending of what kind of data I want to add.

3nids added a commit that referenced this issue Dec 4, 2023
@3nids 3nids self-assigned this Dec 4, 2023
@ponceta
Copy link
Member

ponceta commented Dec 5, 2023

According to @3nids PR #40 , this should be now fixed :
@urskaufmann once the PR is merged, the .qgs project need to be adapted.

Preview of how it could look like :
vw_maintenance_event

@sjib
Copy link
Contributor

sjib commented Dec 5, 2023

@ponceta maintenance_type = unknown should not be possible to be saved as maintenance_event is ABSTRACT!

@ponceta
Copy link
Member

ponceta commented Dec 5, 2023

@ponceta maintenance_type = unknown should not be possible to be saved as maintenance_event is ABSTRACT!

  • We can block the user from validating the form with unknown as value.
  • We remove the unkown value, QGIS will automatically set examination as the first aphabetical item on the list for any new entry (or a default one set by the user).

What is new in QGIS is that we can use enumerations for postgreSQL types.

Possible client adaptations :

image

@3nids 3nids closed this as completed in #40 Dec 5, 2023
3nids added a commit that referenced this issue Dec 5, 2023
* adapt maintenance event view

fixes #33

* Rename vw_maintenance.yaml to vw_maintenance_event.yaml

* Update create_views.py
cymed pushed a commit that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants