DurationFormat Coverage #3592
Merged
DurationFormat Coverage #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romulocintra/test262 into update-duration-format-coverage-methods
romulocintra
changed the title
Ms2ger
previously approved these changes
Jun 30, 2022
|
|
||
| assert.sameValue(typeof format, "function"); | ||
|
|
||
| assert.throws(TypeError, () => format.call(undefined), "undefined"); |
There was a problem hiding this comment.
These are gonna throw anyway even if there's no brand check, because you're not passing a valid object as the duration argument. Compare 9762bc9.
test/intl402/DurationFormat/prototype/format/invalid-arguments-throws.js
Show resolved
Hide resolved
test/intl402/DurationFormat/prototype/format/throw-invoked-as-func.js
Outdated
Show resolved
Hide resolved
|
|
||
| assert.sameValue(typeof formatToParts, "function"); | ||
|
|
||
| assert.throws(TypeError, () => formatToParts.call(undefined), "undefined"); |
test/intl402/DurationFormat/prototype/formatToParts/invalid-arguments-throws.js
Show resolved
Hide resolved
test/intl402/DurationFormat/prototype/formatToParts/not-a-constructor.js
Outdated
Show resolved
Hide resolved
test/intl402/DurationFormat/prototype/formatToParts/not-a-constructor.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
…func.js Co-authored-by: Ms2ger <[email protected]>
…tructor.js Co-authored-by: Ms2ger <[email protected]>
…tructor.js Co-authored-by: Ms2ger <[email protected]>
Ms2ger
approved these changes
Jul 13, 2022
|
Tests |
Thank you for catching this one @iamstolis - fixed in #3605 |
|
@romulocintra, thank you for an extremely fast fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Coverage Intl.DurationFormat #3305