Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Intl DurationFormat API #3305

Closed
6 of 7 tasks
romulocintra opened this issue Nov 11, 2021 · 5 comments
Closed
6 of 7 tasks

Tests for Intl DurationFormat API #3305

romulocintra opened this issue Nov 11, 2021 · 5 comments
Labels
coverage ECMA-402 ECMA-402 related PRs

Comments

@romulocintra
Copy link
Member

romulocintra commented Nov 11, 2021

Hi, opening this issue as a placeholder/reminder for the Intl.DurationFormat tests that advanced to Stage 3 in TC39 2021 October meeting.

https://github.com/tc39/proposal-intl-duration-format

Checklist

  • Basic checks (name, length, prop-desc, slot)
  • Intl.DurationFormat.prototype.constructor
  • Intl.DurationFormat.prototype [ @@toStringTag ]
  • Intl.DurationFormat.prototype.format
  • Intl.DurationFormat.prototype.formatToParts
  • Intl.DurationFormat.prototype.resolvedOptions
  • ...
@jugglinmike
Copy link
Contributor

Thanks, Romulo! If anyone is interested in writing these tests, please comment here. That will help us avoid duplicating effort.

@jugglinmike jugglinmike added coverage ECMA-402 ECMA-402 related PRs labels Nov 11, 2021
@EarthyOrange
Copy link

@jugglinmike I can help out with this.

  • Is this feature already implemented (partially?) in any engine available under esvu which I can use to write tests?
  • If so then is there a flag under which it is being hidden?
  • If not then should I just add (failing) tests based on the proposal?

@EarthyOrange
Copy link

@jugglinmike Can you please take a look at the PR?

@FrankYFTang
Copy link
Contributor

intl402/DurationFormat/constructor-options-defaults.js need to be changed to sync with the changes landed in tc39/proposal-intl-duration-format#185 @ben-allen

@ryzokuken
Copy link
Member

Can we close this? We already have the tests merged at https://github.com/tc39/test262/tree/main/test/intl402/DurationFormat.

@ptomato ptomato closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage ECMA-402 ECMA-402 related PRs
Projects
None yet
Development

No branches or pull requests

6 participants