use stable version 1.0 for "reactjs/react-php-v8js"

[mscharl]

No description provided.

[talyssonoc]

@mscharl Can you please check the breaking test?

[TomCaserta]

Is the breaking test not caused by the v8js extension not being added to php.ini in the test environment? It appears to be failing on my PR too.

[talyssonoc]

@mscharl could you rebase it now that the errors are fixed?

[mscharl]

I should look into my Github Inbox more often.

It seems as if its even worse now.
Before rebasing only PHP 5.4 failed - now all of them fail.

[TomCaserta]

Hmm it looks like its here:

+'Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead.Hello, react-laravel'

This is because we just updated React to 0.14 and the stable version of react-php-v8js I presume uses React.renderToString.

For this to work we will have to either revert back to the old react, implement our own error handler to ignore that warning, create our own polyfill for the console for serverside javascript (so it doesnt actually throw an error for that warning) or finally just not use the stable version of react-php-v8js.

[mscharl]

That sucks ^.^
I think the best solution for now is to not use the stable version and wait :)

[sisve]

I've filed an issue with react-php-v8js to issue another release with the fixes. reactjs/react-php-v8js#21

[sisve]

I've been informed by @TomCaserta that an update in react-php-v8js will not be enough to solve this issue since react-laravel is on a newer version of React than react-php-v8js.

[zpao]

Thanks for filing that issue @sisve. I commented there about what we want to call the version number.

since react-laravel is on a newer version of React than react-php-v8js

Not sure what that means. react-php-v8js in master right now just depends on React 0.14 APIs. We haven't published a newer version of React so not sure how react-laravel would be incompatible (looks like it's using 0.14.6). Once a new stable version of react-php-v8js is out you should be fine.

[TomCaserta]

Yeah he was talking about the current stable version of react-php-v8js being on an older version of react, ie. why this library cannot use the stable version of react-php-v8js without incurring the warnings about React.renderToString being depreciated.