Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Issue new release #21

Closed
sisve opened this issue Feb 4, 2016 · 3 comments
Closed

Issue new release #21

sisve opened this issue Feb 4, 2016 · 3 comments

Comments

@sisve
Copy link

sisve commented Feb 4, 2016

The current stable (1.0.0) is behind the master branch with some important commits that fixes deprecation warnings like "Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead.". A workaround is using dev-master and minimum-stability:dev which makes my skin itch...

The relevant commit: 05637db

@zpao
Copy link
Member

zpao commented Feb 5, 2016

What's the typical way people declare their composer dependencies? If I tag master as 1.1.0, is that likely to break a bunch of people? Should I just call it 2.0.0 to be safe?

@sisve
Copy link
Author

sisve commented Feb 6, 2016

I don't think that you need to consider how people have referenced your library, if they wanted an explicit version they would have explicitly referred to that. Just make sure you're consistent in your versioning and following the semver rules.

  • Are all changes internal backward compatible bug-fixes? Then it's a 1.0.1.
  • Is there new functionality but the public api is backward compatible? Then it's a 1.1.0.
  • Are there backwards incompatible changes in the public api? Then it should be 2.0.0.

@zpao
Copy link
Member

zpao commented Feb 8, 2016

tagged master as 2.0.0

@zpao zpao closed this as completed Feb 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants