Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make honeycomb API key optional #107

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: make honeycomb API key optional #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/app/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ variable "did" {
variable "honeycomb_api_key" {
description = "Ingestion API key to send traces to Honeycomb"
type = string
default = ""
}
2 changes: 1 addition & 1 deletion pkg/aws/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
LegacyBlockIndexTableName: mustGetEnv("LEGACY_BLOCK_INDEX_TABLE_NAME"),
LegacyBlockIndexTableRegion: mustGetEnv("LEGACY_BLOCK_INDEX_TABLE_REGION"),
LegacyDataBucketURL: mustGetEnv("LEGACY_DATA_BUCKET_URL"),
HoneycombAPIKey: mustGetEnv("HONEYCOMB_API_KEY"),
HoneycombAPIKey: os.Getenv("HONEYCOMB_API_KEY"),

Check warning on line 161 in pkg/aws/service.go

View check run for this annotation

Codecov / codecov/patch

pkg/aws/service.go#L161 

Added line #L161 was not covered by tests
}
}

Expand Down