Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make honeycomb API key optional #107

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: make honeycomb API key optional #107

merged 1 commit into from
Feb 5, 2025

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Feb 5, 2025 •
edited
Loading

.env.local template says this is optional and the code (mostly) allows this to be optional.

@alanshaw alanshaw requested a review from volmedo February 5, 2025 13:00
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/aws/service.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/aws/service.go 0.00% <0.00%> (ø)

volmedo
volmedo approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@volmedo volmedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, sorry!

@alanshaw alanshaw merged commit 34a38f8 into main Feb 5, 2025
8 of 9 checks passed
@alanshaw alanshaw deleted the fix/optional-honey branch February 5, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volmedo volmedo volmedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @volmedo